-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force SVG content as non-photo? #900
Comments
Good job changing the photoRegex, that was the right way to work around that. The photoRegex doesn't have to be complicated if you know it's not a photo (e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
By default Colorbox uses a URL regexp to treat certain content as a photo, so for example
.jpg, .png, .svg
, etc all end up in an IMG tag. And the photo:true option overrides the regexp to allow other URLs to be treated as a photo:http://www.jacklmoore.com/colorbox/#setting-photo
However there isn't an option to NOT treat content as a photo. My use case is an SVG file that needs to load as an SVG tag, not as an IMG tag. It would be great if the photo option had 3 values:
A workaround is to explicitly set the photoRegex option to exclude the URLs you don't want treated as photos:
$('A.gallery').colorbox({rel:'gal', photoRegex: /\.(gif|png|jp(e|g|eg)|bmp|ico|webp|jxr)((#|\?).*)?$/i});
another workaround would be to rename the
.svg
file to something else, but that means the content-type is wrong, a server/CDN may not compress it, you can't link directly the file (non-javascript fallback), etc.The text was updated successfully, but these errors were encountered: