Make properties of QueuedQuery
and Batch
public
#1878
Closed
pashagolub
started this conversation in
Ideas
Replies: 1 comment
-
There was no reason specific for these particular properties. Rather it was the general principle of minimizing the API surface area and avoiding being locked into any particular implementation. But I suppose the implementation or interface is unlikely to change at this point -- so I have no objections to making those properties public. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I don't know what is the ratio behind having those properties being private.
My proposal is to make those public to allow programmer, at least, to read those:
Another non-breaking option would be to introduce a public interface with appropriate methods, just like you did for
BatchResults
.My use case is implementing a support for batches in pgxmock. At the moment we need to use dirty hacks to get the content of the queued queries in batch, e.g.
Beta Was this translation helpful? Give feedback.
All reactions