-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isValid
method?
#50
Comments
It looks like this is the case. I don't write TypeScript and not sure if you would accept this PR. |
Yes, @niftylettuce , that is accurate. In your code, you could write I would accept such a PR! I would like to do two things: 1) add a function |
I don't write nor support TypeScript so unfortunately cannot contribute |
@niftylettuce Watch out when using |
Other packages such as
isemail
,@hapi/address
, andvalidator
seem to have validation bugs. Parsing packages such asaddressparser
innodemailer/lib/addressparser
also seem to have issues when parsing certain addresses. It would be useful if this package exposed a simpleisValid
method which returnedtrue
orfalse
. I'm assuming this could be a simple wrapper aroundparseOneAddress
method which checked if the return value had atypeof
with value of"Object"
- but I haven't looked close enough yet to determine if that's the case.The text was updated successfully, but these errors were encountered: