From 94fb47da8c121d24d58e5a9c2103da7ccb6ce8d9 Mon Sep 17 00:00:00 2001 From: Riccardo Balbo Date: Thu, 9 Nov 2023 18:03:41 +0100 Subject: [PATCH 1/6] Deprecate TangentBinormalGenerator --- .../jme3/util/TangentBinormalGenerator.java | 4 +++- .../mikktspace/MikktspaceTangentGenerator.java | 18 +++++++----------- 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/jme3-core/src/main/java/com/jme3/util/TangentBinormalGenerator.java b/jme3-core/src/main/java/com/jme3/util/TangentBinormalGenerator.java index 33c7f4ae11..6422034b1a 100644 --- a/jme3-core/src/main/java/com/jme3/util/TangentBinormalGenerator.java +++ b/jme3-core/src/main/java/com/jme3/util/TangentBinormalGenerator.java @@ -59,9 +59,11 @@ import java.util.logging.Logger; /** - * + * @deprecated This is an outdated and non-standard method. Please use @{link MikktspaceTangentGenerator} + * instead. * @author Lex (Aleksey Nikiforov) */ +@Deprecated public class TangentBinormalGenerator { private static final Logger log = Logger.getLogger(TangentBinormalGenerator.class.getName()); diff --git a/jme3-core/src/main/java/com/jme3/util/mikktspace/MikktspaceTangentGenerator.java b/jme3-core/src/main/java/com/jme3/util/mikktspace/MikktspaceTangentGenerator.java index 27375469e4..dcd3157ddd 100644 --- a/jme3-core/src/main/java/com/jme3/util/mikktspace/MikktspaceTangentGenerator.java +++ b/jme3-core/src/main/java/com/jme3/util/mikktspace/MikktspaceTangentGenerator.java @@ -43,19 +43,15 @@ import java.util.logging.Logger; /** - * This tangent generator is highly experimental. - * This is the Java translation of the mikktspace generator made by Morten S. Mikkelsen - * C Source code can be found here - * https://developer.blender.org/diffusion/B/browse/master/intern/mikktspace/mikktspace.c - * https://developer.blender.org/diffusion/B/browse/master/intern/mikktspace/mikktspace.h - * - * Mikktspace looks like the new standard of tangent generation in 3-D software. - * Xnormal, Blender, Substance painter, and many more use it. - * - * Usage is : - * MikktspaceTangentGenerator.generate(spatial); + * Mikktspace is a common standard for tangent space used across many 3D software. * + * This is the Java translation of the mikktspace generator made by Morten S. Mikkelsen C Source code can be + * found here https://developer.blender.org/diffusion/B/browse/master/intern/mikktspace/mikktspace.c + * https://developer.blender.org/diffusion/B/browse/master/intern/mikktspace/mikktspace.h * + * Usage is : + * MikktspaceTangentGenerator.generate(spatial); + * * * @author Nehon */ From d82b9a7ff187cc520de121c2c9d10fea971d21bd Mon Sep 17 00:00:00 2001 From: Riccardo Balbo Date: Thu, 9 Nov 2023 18:30:36 +0100 Subject: [PATCH 2/6] Print a SEVERE log instead of throwing an exception when trying to compute tangent for unsupported mesh types. Add generate(Mesh) method to match TangentBinormalGenerator --- .../MikktspaceTangentGenerator.java | 67 +++++++++++-------- 1 file changed, 40 insertions(+), 27 deletions(-) diff --git a/jme3-core/src/main/java/com/jme3/util/mikktspace/MikktspaceTangentGenerator.java b/jme3-core/src/main/java/com/jme3/util/mikktspace/MikktspaceTangentGenerator.java index dcd3157ddd..49792fb396 100644 --- a/jme3-core/src/main/java/com/jme3/util/mikktspace/MikktspaceTangentGenerator.java +++ b/jme3-core/src/main/java/com/jme3/util/mikktspace/MikktspaceTangentGenerator.java @@ -112,36 +112,49 @@ public static void generate(Spatial s){ } else if (s instanceof Geometry) { Geometry g = (Geometry) s; Mesh mesh = g.getMesh(); - - Mesh.Mode mode = mesh.getMode(); - boolean hasTriangles; - switch (mode) { - case Points: - case Lines: - case LineStrip: - case LineLoop: - hasTriangles = false; // skip this mesh - break; - - case Triangles: - case TriangleFan: - case TriangleStrip: - hasTriangles = true; - break; - - default: - String message = "Tangent generation isn't implemented for mode=" + mode; - throw new UnsupportedOperationException(message); + boolean success = generateTangents(mesh); + if (!success) { + logger.log(Level.SEVERE, "Failed to generate tangents for geometry {0}", g.getName()); } + } + } - if (hasTriangles) { - MikkTSpaceImpl context = new MikkTSpaceImpl(mesh); - if (!genTangSpaceDefault(context)) { - logger.log(Level.SEVERE, "Failed to generate tangents for geometry {0}", g.getName()); - } - TangentUtils.generateBindPoseTangentsIfNecessary(mesh); - } + public static void generate(Mesh mesh) { + boolean success = generateTangents(mesh); + if (!success) { + logger.log(Level.SEVERE, "Failed to generate tangents for mesh {0}", mesh); + } + } + + private static boolean generateTangents(Mesh mesh) { + Mesh.Mode mode = mesh.getMode(); + boolean hasTriangles; + switch (mode) { + case Points: + case Lines: + case LineStrip: + case LineLoop: + hasTriangles = false; // skip this mesh + break; + + case Triangles: + case TriangleFan: + case TriangleStrip: + hasTriangles = true; + break; + + default: + logger.log(Level.SEVERE, "Tangent generation isn't implemented for mode={0}", mode); + return false; + } + + if (hasTriangles) { + MikkTSpaceImpl context = new MikkTSpaceImpl(mesh); + boolean result = genTangSpaceDefault(context); + TangentUtils.generateBindPoseTangentsIfNecessary(mesh); + return result; } + return false; } public static boolean genTangSpaceDefault(MikkTSpaceContext mikkTSpace) { From 7e3458993193a554fa0ee6d85e3374723cc95070 Mon Sep 17 00:00:00 2001 From: Riccardo Balbo Date: Thu, 9 Nov 2023 18:39:31 +0100 Subject: [PATCH 3/6] Move methods used to generate debug lines for tangent and normals from TangentBinormalGenerator to TangentUtils --- .../jme3/util/TangentBinormalGenerator.java | 141 ++--------------- .../main/java/com/jme3/util/TangentUtils.java | 148 ++++++++++++++++++ 2 files changed, 158 insertions(+), 131 deletions(-) diff --git a/jme3-core/src/main/java/com/jme3/util/TangentBinormalGenerator.java b/jme3-core/src/main/java/com/jme3/util/TangentBinormalGenerator.java index 6422034b1a..f19aacd914 100644 --- a/jme3-core/src/main/java/com/jme3/util/TangentBinormalGenerator.java +++ b/jme3-core/src/main/java/com/jme3/util/TangentBinormalGenerator.java @@ -862,142 +862,21 @@ private static int parity(Vector3f n1, Vector3f n) { } } + /** + * @deprecated Use {@link TangentUtils#genTbnLines(com.jme3.scene.Mesh, float) } instead. + */ + @Deprecated public static Mesh genTbnLines(Mesh mesh, float scale) { - if (mesh.getBuffer(Type.Tangent) == null) { - return genNormalLines(mesh, scale); - } else { - return genTangentLines(mesh, scale); - } + return TangentUtils.genTbnLines(mesh, scale); } + /** + * @deprecated Use {@link TangentUtils#genNormalLines(com.jme3.scene.Mesh, float) } instead. + */ + @Deprecated public static Mesh genNormalLines(Mesh mesh, float scale) { - FloatBuffer vertexBuffer = (FloatBuffer) mesh.getBuffer(Type.Position).getData(); - FloatBuffer normalBuffer = (FloatBuffer) mesh.getBuffer(Type.Normal).getData(); - - ColorRGBA originColor = ColorRGBA.White; - ColorRGBA normalColor = ColorRGBA.Blue; - - Mesh lineMesh = new Mesh(); - lineMesh.setMode(Mesh.Mode.Lines); - - Vector3f origin = new Vector3f(); - Vector3f point = new Vector3f(); - - FloatBuffer lineVertex = BufferUtils.createFloatBuffer(vertexBuffer.limit() * 2); - FloatBuffer lineColor = BufferUtils.createFloatBuffer(vertexBuffer.limit() / 3 * 4 * 2); - - for (int i = 0; i < vertexBuffer.limit() / 3; i++) { - populateFromBuffer(origin, vertexBuffer, i); - populateFromBuffer(point, normalBuffer, i); - - int index = i * 2; - - setInBuffer(origin, lineVertex, index); - setInBuffer(originColor, lineColor, index); - - point.multLocal(scale); - point.addLocal(origin); - setInBuffer(point, lineVertex, index + 1); - setInBuffer(normalColor, lineColor, index + 1); - } - - lineMesh.setBuffer(Type.Position, 3, lineVertex); - lineMesh.setBuffer(Type.Color, 4, lineColor); - - lineMesh.setStatic(); - //lineMesh.setInterleaved(); - return lineMesh; + return TangentUtils.genNormalLines(mesh, scale); } - private static Mesh genTangentLines(Mesh mesh, float scale) { - FloatBuffer vertexBuffer = (FloatBuffer) mesh.getBuffer(Type.Position).getData(); - FloatBuffer normalBuffer = (FloatBuffer) mesh.getBuffer(Type.Normal).getData(); - FloatBuffer tangentBuffer = (FloatBuffer) mesh.getBuffer(Type.Tangent).getData(); - - FloatBuffer binormalBuffer = null; - if (mesh.getBuffer(Type.Binormal) != null) { - binormalBuffer = (FloatBuffer) mesh.getBuffer(Type.Binormal).getData(); - } - ColorRGBA originColor = ColorRGBA.White; - ColorRGBA tangentColor = ColorRGBA.Red; - ColorRGBA binormalColor = ColorRGBA.Green; - ColorRGBA normalColor = ColorRGBA.Blue; - - Mesh lineMesh = new Mesh(); - lineMesh.setMode(Mesh.Mode.Lines); - - Vector3f origin = new Vector3f(); - Vector3f point = new Vector3f(); - Vector3f tangent = new Vector3f(); - Vector3f normal = new Vector3f(); - - IntBuffer lineIndex = BufferUtils.createIntBuffer(vertexBuffer.limit() / 3 * 6); - FloatBuffer lineVertex = BufferUtils.createFloatBuffer(vertexBuffer.limit() * 4); - FloatBuffer lineColor = BufferUtils.createFloatBuffer(vertexBuffer.limit() / 3 * 4 * 4); - - boolean hasParity = mesh.getBuffer(Type.Tangent).getNumComponents() == 4; - float tangentW = 1; - - for (int i = 0; i < vertexBuffer.limit() / 3; i++) { - populateFromBuffer(origin, vertexBuffer, i); - populateFromBuffer(normal, normalBuffer, i); - - if (hasParity) { - tangent.x = tangentBuffer.get(i * 4); - tangent.y = tangentBuffer.get(i * 4 + 1); - tangent.z = tangentBuffer.get(i * 4 + 2); - tangentW = tangentBuffer.get(i * 4 + 3); - } else { - populateFromBuffer(tangent, tangentBuffer, i); - } - - int index = i * 4; - - int id = i * 6; - lineIndex.put(id, index); - lineIndex.put(id + 1, index + 1); - lineIndex.put(id + 2, index); - lineIndex.put(id + 3, index + 2); - lineIndex.put(id + 4, index); - lineIndex.put(id + 5, index + 3); - - setInBuffer(origin, lineVertex, index); - setInBuffer(originColor, lineColor, index); - - point.set(tangent); - point.multLocal(scale); - point.addLocal(origin); - setInBuffer(point, lineVertex, index + 1); - setInBuffer(tangentColor, lineColor, index + 1); - - // wvBinormal = cross(wvNormal, wvTangent) * -inTangent.w - if (binormalBuffer == null) { - normal.cross(tangent, point); - point.multLocal(-tangentW); - point.normalizeLocal(); - } else { - populateFromBuffer(point, binormalBuffer, i); - } - - point.multLocal(scale); - point.addLocal(origin); - setInBuffer(point, lineVertex, index + 2); - setInBuffer(binormalColor, lineColor, index + 2); - - point.set(normal); - point.multLocal(scale); - point.addLocal(origin); - setInBuffer(point, lineVertex, index + 3); - setInBuffer(normalColor, lineColor, index + 3); - } - - lineMesh.setBuffer(Type.Index, 1, lineIndex); - lineMesh.setBuffer(Type.Position, 3, lineVertex); - lineMesh.setBuffer(Type.Color, 4, lineColor); - - lineMesh.setStatic(); - //lineMesh.setInterleaved(); - return lineMesh; - } } diff --git a/jme3-core/src/main/java/com/jme3/util/TangentUtils.java b/jme3-core/src/main/java/com/jme3/util/TangentUtils.java index 7ae2737d26..2014eaf003 100644 --- a/jme3-core/src/main/java/com/jme3/util/TangentUtils.java +++ b/jme3-core/src/main/java/com/jme3/util/TangentUtils.java @@ -31,7 +31,16 @@ */ package com.jme3.util; +import static com.jme3.util.BufferUtils.populateFromBuffer; +import static com.jme3.util.BufferUtils.setInBuffer; + +import java.nio.FloatBuffer; +import java.nio.IntBuffer; + +import com.jme3.math.ColorRGBA; +import com.jme3.math.Vector3f; import com.jme3.scene.*; +import com.jme3.scene.VertexBuffer.Type; /** * Created by Nehon on 03/10/2016. @@ -63,4 +72,143 @@ public static void generateBindPoseTangentsIfNecessary(Mesh mesh){ } } } + + public static Mesh genTbnLines(Mesh mesh, float scale) { + if (mesh.getBuffer(Type.Tangent) == null) { + return genNormalLines(mesh, scale); + } else { + return genTangentLines(mesh, scale); + } + } + + public static Mesh genNormalLines(Mesh mesh, float scale) { + FloatBuffer vertexBuffer = (FloatBuffer) mesh.getBuffer(Type.Position).getData(); + FloatBuffer normalBuffer = (FloatBuffer) mesh.getBuffer(Type.Normal).getData(); + + ColorRGBA originColor = ColorRGBA.White; + ColorRGBA normalColor = ColorRGBA.Blue; + + Mesh lineMesh = new Mesh(); + lineMesh.setMode(Mesh.Mode.Lines); + + Vector3f origin = new Vector3f(); + Vector3f point = new Vector3f(); + + FloatBuffer lineVertex = BufferUtils.createFloatBuffer(vertexBuffer.limit() * 2); + FloatBuffer lineColor = BufferUtils.createFloatBuffer(vertexBuffer.limit() / 3 * 4 * 2); + + for (int i = 0; i < vertexBuffer.limit() / 3; i++) { + populateFromBuffer(origin, vertexBuffer, i); + populateFromBuffer(point, normalBuffer, i); + + int index = i * 2; + + setInBuffer(origin, lineVertex, index); + setInBuffer(originColor, lineColor, index); + + point.multLocal(scale); + point.addLocal(origin); + setInBuffer(point, lineVertex, index + 1); + setInBuffer(normalColor, lineColor, index + 1); + } + + lineMesh.setBuffer(Type.Position, 3, lineVertex); + lineMesh.setBuffer(Type.Color, 4, lineColor); + + lineMesh.setStatic(); + // lineMesh.setInterleaved(); + return lineMesh; + } + + public static Mesh genTangentLines(Mesh mesh, float scale) { + FloatBuffer vertexBuffer = (FloatBuffer) mesh.getBuffer(Type.Position).getData(); + FloatBuffer normalBuffer = (FloatBuffer) mesh.getBuffer(Type.Normal).getData(); + FloatBuffer tangentBuffer = (FloatBuffer) mesh.getBuffer(Type.Tangent).getData(); + + FloatBuffer binormalBuffer = null; + if (mesh.getBuffer(Type.Binormal) != null) { + binormalBuffer = (FloatBuffer) mesh.getBuffer(Type.Binormal).getData(); + } + + ColorRGBA originColor = ColorRGBA.White; + ColorRGBA tangentColor = ColorRGBA.Red; + ColorRGBA binormalColor = ColorRGBA.Green; + ColorRGBA normalColor = ColorRGBA.Blue; + + Mesh lineMesh = new Mesh(); + lineMesh.setMode(Mesh.Mode.Lines); + + Vector3f origin = new Vector3f(); + Vector3f point = new Vector3f(); + Vector3f tangent = new Vector3f(); + Vector3f normal = new Vector3f(); + + IntBuffer lineIndex = BufferUtils.createIntBuffer(vertexBuffer.limit() / 3 * 6); + FloatBuffer lineVertex = BufferUtils.createFloatBuffer(vertexBuffer.limit() * 4); + FloatBuffer lineColor = BufferUtils.createFloatBuffer(vertexBuffer.limit() / 3 * 4 * 4); + + boolean hasParity = mesh.getBuffer(Type.Tangent).getNumComponents() == 4; + float tangentW = 1; + + for (int i = 0; i < vertexBuffer.limit() / 3; i++) { + populateFromBuffer(origin, vertexBuffer, i); + populateFromBuffer(normal, normalBuffer, i); + + if (hasParity) { + tangent.x = tangentBuffer.get(i * 4); + tangent.y = tangentBuffer.get(i * 4 + 1); + tangent.z = tangentBuffer.get(i * 4 + 2); + tangentW = tangentBuffer.get(i * 4 + 3); + } else { + populateFromBuffer(tangent, tangentBuffer, i); + } + + int index = i * 4; + + int id = i * 6; + lineIndex.put(id, index); + lineIndex.put(id + 1, index + 1); + lineIndex.put(id + 2, index); + lineIndex.put(id + 3, index + 2); + lineIndex.put(id + 4, index); + lineIndex.put(id + 5, index + 3); + + setInBuffer(origin, lineVertex, index); + setInBuffer(originColor, lineColor, index); + + point.set(tangent); + point.multLocal(scale); + point.addLocal(origin); + setInBuffer(point, lineVertex, index + 1); + setInBuffer(tangentColor, lineColor, index + 1); + + // wvBinormal = cross(wvNormal, wvTangent) * -inTangent.w + if (binormalBuffer == null) { + normal.cross(tangent, point); + point.multLocal(-tangentW); + point.normalizeLocal(); + } else { + populateFromBuffer(point, binormalBuffer, i); + } + + point.multLocal(scale); + point.addLocal(origin); + setInBuffer(point, lineVertex, index + 2); + setInBuffer(binormalColor, lineColor, index + 2); + + point.set(normal); + point.multLocal(scale); + point.addLocal(origin); + setInBuffer(point, lineVertex, index + 3); + setInBuffer(normalColor, lineColor, index + 3); + } + + lineMesh.setBuffer(Type.Index, 1, lineIndex); + lineMesh.setBuffer(Type.Position, 3, lineVertex); + lineMesh.setBuffer(Type.Color, 4, lineColor); + + lineMesh.setStatic(); + // lineMesh.setInterleaved(); + return lineMesh; + } } From 07ff207b91474d37f2dd30aef6fc1b59629478b6 Mon Sep 17 00:00:00 2001 From: Riccardo Balbo Date: Thu, 9 Nov 2023 18:42:36 +0100 Subject: [PATCH 4/6] Replace most of the occurencies of TangentBinormalGenerator with Mikktspace --- .../src/main/java/jme3test/batching/TestBatchNode.java | 6 +++--- .../src/main/java/jme3test/effect/TestEverything.java | 4 ++-- .../src/main/java/jme3test/helloworld/HelloMaterial.java | 4 ++-- .../java/jme3test/light/TestDirectionalLightShadow.java | 6 +++--- .../src/main/java/jme3test/light/TestShadowsPerf.java | 4 ++-- .../src/main/java/jme3test/light/TestSimpleLighting.java | 4 ++-- .../src/main/java/jme3test/light/TestSpotLight.java | 6 +++--- .../main/java/jme3test/light/TestSpotLightShadows.java | 6 +++--- .../src/main/java/jme3test/light/TestTangentCube.java | 4 ++-- .../src/main/java/jme3test/light/TestTangentGen.java | 8 +++++--- .../src/main/java/jme3test/light/TestTangentGenBadUV.java | 6 +++--- .../src/main/java/jme3test/light/TestTangentSpace.java | 3 ++- .../main/java/jme3test/light/TestTransparentShadow.java | 4 ++-- .../src/main/java/jme3test/light/TestTwoSideLighting.java | 4 ++-- .../src/main/java/jme3test/material/TestBumpModel.java | 4 ++-- .../main/java/jme3test/material/TestNormalMapping.java | 4 ++-- .../src/main/java/jme3test/material/TestParallax.java | 6 +++--- .../src/main/java/jme3test/material/TestParallaxPBR.java | 6 +++--- .../src/main/java/jme3test/material/TestSimpleBumps.java | 4 ++-- .../main/java/jme3test/material/TestUnshadedModel.java | 4 ++-- .../java/jme3test/model/anim/TestAnimationFactory.java | 4 ++-- .../src/main/java/jme3test/post/TestLightScattering.java | 4 ++-- .../src/main/java/jme3test/post/TestPostFilters.java | 4 ++-- .../src/main/java/jme3test/post/TestTransparentSSAO.java | 4 ++-- .../main/java/com/jme3/terrain/geomipmap/TerrainQuad.java | 4 ++-- 25 files changed, 60 insertions(+), 57 deletions(-) diff --git a/jme3-examples/src/main/java/jme3test/batching/TestBatchNode.java b/jme3-examples/src/main/java/jme3test/batching/TestBatchNode.java index c04069ef88..b8037f4a19 100644 --- a/jme3-examples/src/main/java/jme3test/batching/TestBatchNode.java +++ b/jme3-examples/src/main/java/jme3test/batching/TestBatchNode.java @@ -45,7 +45,7 @@ import com.jme3.scene.debug.WireFrustum; import com.jme3.scene.shape.Box; import com.jme3.system.NanoTimer; -import com.jme3.util.TangentBinormalGenerator; +import com.jme3.util.mikktspace.MikktspaceTangentGenerator; /** * A test to demonstrate the usage and functionality of the {@link BatchNode} @@ -96,8 +96,8 @@ public void simpleInitApp() { cube2 = new Geometry("cube2", box); cube2.setMaterial(mat); - TangentBinormalGenerator.generate(cube); - TangentBinormalGenerator.generate(cube2); + MikktspaceTangentGenerator.generate(cube); + MikktspaceTangentGenerator.generate(cube2); batch.attachChild(cube); // batch.attachChild(cube2); diff --git a/jme3-examples/src/main/java/jme3test/effect/TestEverything.java b/jme3-examples/src/main/java/jme3test/effect/TestEverything.java index b579a03601..bb5ab62a1a 100644 --- a/jme3-examples/src/main/java/jme3test/effect/TestEverything.java +++ b/jme3-examples/src/main/java/jme3test/effect/TestEverything.java @@ -48,7 +48,7 @@ import com.jme3.shadow.DirectionalLightShadowRenderer; import com.jme3.texture.Texture; import com.jme3.util.SkyFactory; -import com.jme3.util.TangentBinormalGenerator; +import com.jme3.util.mikktspace.MikktspaceTangentGenerator; public class TestEverything extends SimpleApplication { @@ -122,7 +122,7 @@ public void setupLighting(){ public void setupFloor(){ Material mat = assetManager.loadMaterial("Textures/Terrain/BrickWall/BrickWall.j3m"); Box floor = new Box(50, 1f, 50); - TangentBinormalGenerator.generate(floor); + MikktspaceTangentGenerator.generate(floor); floor.scaleTextureCoordinates(new Vector2f(5, 5)); Geometry floorGeom = new Geometry("Floor", floor); floorGeom.setMaterial(mat); diff --git a/jme3-examples/src/main/java/jme3test/helloworld/HelloMaterial.java b/jme3-examples/src/main/java/jme3test/helloworld/HelloMaterial.java index e12fef4569..a9e4b4f28a 100644 --- a/jme3-examples/src/main/java/jme3test/helloworld/HelloMaterial.java +++ b/jme3-examples/src/main/java/jme3test/helloworld/HelloMaterial.java @@ -43,7 +43,7 @@ import com.jme3.scene.shape.Box; import com.jme3.scene.shape.Sphere; import com.jme3.texture.Texture; -import com.jme3.util.TangentBinormalGenerator; +import com.jme3.util.mikktspace.MikktspaceTangentGenerator; /** Sample 6 - how to give an object's surface a material and texture. * How to make objects transparent. How to make bumpy and shiny surfaces. */ @@ -81,7 +81,7 @@ public void simpleInitApp() { Sphere sphereMesh = new Sphere(32,32, 2f); Geometry sphereGeo = new Geometry("Shiny rock", sphereMesh); sphereMesh.setTextureMode(Sphere.TextureMode.Projected); // better quality on spheres - TangentBinormalGenerator.generate(sphereMesh); // for lighting effect + MikktspaceTangentGenerator.generate(sphereMesh); // for lighting effect Material sphereMat = new Material(assetManager, "Common/MatDefs/Light/Lighting.j3md"); sphereMat.setTexture("DiffuseMap", assetManager.loadTexture("Textures/Terrain/Pond/Pond.jpg")); sphereMat.setTexture("NormalMap", assetManager.loadTexture("Textures/Terrain/Pond/Pond_normal.png")); diff --git a/jme3-examples/src/main/java/jme3test/light/TestDirectionalLightShadow.java b/jme3-examples/src/main/java/jme3test/light/TestDirectionalLightShadow.java index 81a268fdf4..0c6f437305 100644 --- a/jme3-examples/src/main/java/jme3test/light/TestDirectionalLightShadow.java +++ b/jme3-examples/src/main/java/jme3test/light/TestDirectionalLightShadow.java @@ -58,7 +58,7 @@ import com.jme3.texture.Texture.WrapMode; import com.jme3.util.SkyFactory; import com.jme3.util.SkyFactory.EnvMapType; -import com.jme3.util.TangentBinormalGenerator; +import com.jme3.util.mikktspace.MikktspaceTangentGenerator; public class TestDirectionalLightShadow extends SimpleApplication implements ActionListener, AnalogListener { @@ -108,8 +108,8 @@ public void loadScene() { obj[0].setShadowMode(ShadowMode.CastAndReceive); obj[1] = new Geometry("cube", new Box(1.0f, 1.0f, 1.0f)); obj[1].setShadowMode(ShadowMode.CastAndReceive); - TangentBinormalGenerator.generate(obj[1]); - TangentBinormalGenerator.generate(obj[0]); + MikktspaceTangentGenerator.generate(obj[1]); + MikktspaceTangentGenerator.generate(obj[0]); Spatial t = obj[0].clone(false); t.setLocalScale(10f); diff --git a/jme3-examples/src/main/java/jme3test/light/TestShadowsPerf.java b/jme3-examples/src/main/java/jme3test/light/TestShadowsPerf.java index 857d4374fe..600e60cc95 100644 --- a/jme3-examples/src/main/java/jme3test/light/TestShadowsPerf.java +++ b/jme3-examples/src/main/java/jme3test/light/TestShadowsPerf.java @@ -48,7 +48,7 @@ import com.jme3.scene.shape.Sphere; import com.jme3.shadow.DirectionalLightShadowRenderer; import com.jme3.shadow.EdgeFilteringMode; -import com.jme3.util.TangentBinormalGenerator; +import com.jme3.util.mikktspace.MikktspaceTangentGenerator; public class TestShadowsPerf extends SimpleApplication { @@ -84,7 +84,7 @@ public void simpleInitApp() { Sphere sphMesh = new Sphere(32, 32, 1); sphMesh.setTextureMode(Sphere.TextureMode.Projected); sphMesh.updateGeometry(32, 32, 1, false, false); - TangentBinormalGenerator.generate(sphMesh); + MikktspaceTangentGenerator.generate(sphMesh); sphere = new Geometry("Rock Ball", sphMesh); sphere.setLocalTranslation(0, 5, 0); diff --git a/jme3-examples/src/main/java/jme3test/light/TestSimpleLighting.java b/jme3-examples/src/main/java/jme3test/light/TestSimpleLighting.java index 535db645d3..dba24ad18d 100644 --- a/jme3-examples/src/main/java/jme3test/light/TestSimpleLighting.java +++ b/jme3-examples/src/main/java/jme3test/light/TestSimpleLighting.java @@ -43,7 +43,7 @@ import com.jme3.scene.Geometry; import com.jme3.scene.shape.Sphere; import com.jme3.util.MaterialDebugAppState; -import com.jme3.util.TangentBinormalGenerator; +import com.jme3.util.mikktspace.MikktspaceTangentGenerator; public class TestSimpleLighting extends SimpleApplication { @@ -59,7 +59,7 @@ public static void main(String[] args){ @Override public void simpleInitApp() { Geometry teapot = (Geometry) assetManager.loadModel("Models/Teapot/Teapot.obj"); - TangentBinormalGenerator.generate(teapot.getMesh(), true); + MikktspaceTangentGenerator.generate(teapot.getMesh()); teapot.setLocalScale(2f); Material mat = new Material(assetManager, "Common/MatDefs/Light/Lighting.j3md"); diff --git a/jme3-examples/src/main/java/jme3test/light/TestSpotLight.java b/jme3-examples/src/main/java/jme3test/light/TestSpotLight.java index e65c1763da..ed53b0de35 100644 --- a/jme3-examples/src/main/java/jme3test/light/TestSpotLight.java +++ b/jme3-examples/src/main/java/jme3test/light/TestSpotLight.java @@ -43,7 +43,7 @@ import com.jme3.scene.shape.Box; import com.jme3.scene.shape.Sphere; import com.jme3.texture.Texture.WrapMode; -import com.jme3.util.TangentBinormalGenerator; +import com.jme3.util.mikktspace.MikktspaceTangentGenerator; public class TestSpotLight extends SimpleApplication { @@ -101,7 +101,7 @@ public void setupFloor(){ Box floor = new Box(50, 1f, 50); - TangentBinormalGenerator.generate(floor); + MikktspaceTangentGenerator.generate(floor); floor.scaleTextureCoordinates(new Vector2f(5, 5)); Geometry floorGeom = new Geometry("Floor", floor); floorGeom.setMaterial(mat); @@ -120,7 +120,7 @@ public void setupSignpost(){ signpost.setLocalTranslation(12, 3.5f, 30); signpost.setLocalScale(4); signpost.setShadowMode(ShadowMode.CastAndReceive); - TangentBinormalGenerator.generate(signpost); + MikktspaceTangentGenerator.generate(signpost); rootNode.attachChild(signpost); } diff --git a/jme3-examples/src/main/java/jme3test/light/TestSpotLightShadows.java b/jme3-examples/src/main/java/jme3test/light/TestSpotLightShadows.java index 40e066d62b..11dd519ef3 100644 --- a/jme3-examples/src/main/java/jme3test/light/TestSpotLightShadows.java +++ b/jme3-examples/src/main/java/jme3test/light/TestSpotLightShadows.java @@ -49,7 +49,7 @@ import com.jme3.shadow.SpotLightShadowFilter; import com.jme3.shadow.SpotLightShadowRenderer; import com.jme3.texture.Texture.WrapMode; -import com.jme3.util.TangentBinormalGenerator; +import com.jme3.util.mikktspace.MikktspaceTangentGenerator; public class TestSpotLightShadows extends SimpleApplication { @@ -149,7 +149,7 @@ public void setupFloor() { Box floor = new Box(50, 1f, 50); - TangentBinormalGenerator.generate(floor); + MikktspaceTangentGenerator.generate(floor); floor.scaleTextureCoordinates(new Vector2f(5, 5)); Geometry floorGeom = new Geometry("Floor", floor); floorGeom.setMaterial(mat); @@ -166,7 +166,7 @@ public void setupSignpost() { signpost.setLocalTranslation(12, 3.5f, 30); signpost.setLocalScale(4); signpost.setShadowMode(ShadowMode.CastAndReceive); - TangentBinormalGenerator.generate(signpost); + MikktspaceTangentGenerator.generate(signpost); rootNode.attachChild(signpost); } diff --git a/jme3-examples/src/main/java/jme3test/light/TestTangentCube.java b/jme3-examples/src/main/java/jme3test/light/TestTangentCube.java index 13841f986f..d173eeafd8 100644 --- a/jme3-examples/src/main/java/jme3test/light/TestTangentCube.java +++ b/jme3-examples/src/main/java/jme3test/light/TestTangentCube.java @@ -40,7 +40,7 @@ import com.jme3.math.Vector3f; import com.jme3.scene.Geometry; import com.jme3.scene.shape.Box; -import com.jme3.util.TangentBinormalGenerator; +import com.jme3.util.mikktspace.MikktspaceTangentGenerator; /** * @@ -57,7 +57,7 @@ public static void main(String... args) { public void simpleInitApp() { Box aBox = new Box(1, 1, 1); Geometry aGeometry = new Geometry("Box", aBox); - TangentBinormalGenerator.generate(aBox); + MikktspaceTangentGenerator.generate(aBox); Material aMaterial = new Material(assetManager, "Common/MatDefs/Light/Lighting.j3md"); aMaterial.setTexture("DiffuseMap", diff --git a/jme3-examples/src/main/java/jme3test/light/TestTangentGen.java b/jme3-examples/src/main/java/jme3test/light/TestTangentGen.java index 80fd44084c..2337c0bca9 100644 --- a/jme3-examples/src/main/java/jme3test/light/TestTangentGen.java +++ b/jme3-examples/src/main/java/jme3test/light/TestTangentGen.java @@ -45,7 +45,9 @@ import com.jme3.scene.shape.Quad; import com.jme3.scene.shape.Sphere; import com.jme3.util.BufferUtils; -import com.jme3.util.TangentBinormalGenerator; +import com.jme3.util.TangentUtils; +import com.jme3.util.mikktspace.MikktspaceTangentGenerator; + import java.nio.FloatBuffer; import java.nio.IntBuffer; @@ -79,7 +81,7 @@ public void simpleInitApp() { } private void addMesh(String name, Mesh mesh, Vector3f translation) { - TangentBinormalGenerator.generate(mesh); + MikktspaceTangentGenerator.generate(mesh); Geometry testGeom = new Geometry(name, mesh); Material mat = assetManager.loadMaterial("Textures/BumpMapTest/Tangent.j3m"); @@ -89,7 +91,7 @@ private void addMesh(String name, Mesh mesh, Vector3f translation) { Geometry debug = new Geometry( "Debug " + name, - TangentBinormalGenerator.genTbnLines(mesh, 0.08f) + TangentUtils.genTbnLines(mesh, 0.08f) ); Material debugMat = assetManager.loadMaterial("Common/Materials/VertexColor.j3m"); debug.setMaterial(debugMat); diff --git a/jme3-examples/src/main/java/jme3test/light/TestTangentGenBadUV.java b/jme3-examples/src/main/java/jme3test/light/TestTangentGenBadUV.java index 9121d09154..6d1e937631 100644 --- a/jme3-examples/src/main/java/jme3test/light/TestTangentGenBadUV.java +++ b/jme3-examples/src/main/java/jme3test/light/TestTangentGenBadUV.java @@ -42,7 +42,7 @@ import com.jme3.scene.Geometry; import com.jme3.scene.Spatial; import com.jme3.scene.shape.Sphere; -import com.jme3.util.TangentBinormalGenerator; +import com.jme3.util.mikktspace.MikktspaceTangentGenerator; public class TestTangentGenBadUV extends SimpleApplication { @@ -60,7 +60,7 @@ public void simpleInitApp() { Spatial teapot = assetManager.loadModel("Models/Teapot/Teapot.obj"); if (teapot instanceof Geometry){ Geometry g = (Geometry) teapot; - TangentBinormalGenerator.generate(g.getMesh()); + MikktspaceTangentGenerator.generate(g.getMesh()); }else{ throw new RuntimeException(); } @@ -71,7 +71,7 @@ public void simpleInitApp() { Geometry debug = new Geometry( "Debug Teapot", - TangentBinormalGenerator.genTbnLines(((Geometry) teapot).getMesh(), 0.03f) + MikktspaceTangentGenerator.genTbnLines(((Geometry) teapot).getMesh(), 0.03f) ); Material debugMat = assetManager.loadMaterial("Common/Materials/VertexColor.j3m"); debug.setMaterial(debugMat); diff --git a/jme3-examples/src/main/java/jme3test/light/TestTangentSpace.java b/jme3-examples/src/main/java/jme3test/light/TestTangentSpace.java index f4cd8c4215..d3201cce99 100644 --- a/jme3-examples/src/main/java/jme3test/light/TestTangentSpace.java +++ b/jme3-examples/src/main/java/jme3test/light/TestTangentSpace.java @@ -44,6 +44,7 @@ import com.jme3.scene.Node; import com.jme3.scene.Spatial; import com.jme3.util.TangentBinormalGenerator; +import com.jme3.util.TangentUtils; import com.jme3.util.mikktspace.MikktspaceTangentGenerator; /** @@ -120,7 +121,7 @@ private void initView() { private void createDebugTangents(Geometry geom) { Geometry debug = new Geometry( "Debug " + geom.getName(), - TangentBinormalGenerator.genTbnLines(geom.getMesh(), 0.8f) + TangentUtils.genTbnLines(geom.getMesh(), 0.8f) ); Material debugMat = assetManager.loadMaterial("Common/Materials/VertexColor.j3m"); debug.setMaterial(debugMat); diff --git a/jme3-examples/src/main/java/jme3test/light/TestTransparentShadow.java b/jme3-examples/src/main/java/jme3test/light/TestTransparentShadow.java index b013dc6c1d..16229161d9 100644 --- a/jme3-examples/src/main/java/jme3test/light/TestTransparentShadow.java +++ b/jme3-examples/src/main/java/jme3test/light/TestTransparentShadow.java @@ -50,7 +50,7 @@ import com.jme3.shadow.CompareMode; import com.jme3.shadow.DirectionalLightShadowRenderer; import com.jme3.shadow.EdgeFilteringMode; -import com.jme3.util.TangentBinormalGenerator; +import com.jme3.util.mikktspace.MikktspaceTangentGenerator; public class TestTransparentShadow extends SimpleApplication { @@ -72,7 +72,7 @@ public void simpleInitApp() { new Vector3f(-10, 0, -10) ); rm.scaleTextureCoordinates(Vector2f.UNIT_XY.mult(10)); - TangentBinormalGenerator.generate(rm); + MikktspaceTangentGenerator.generate(rm); Geometry geom = new Geometry("floor", rm); Material mat = assetManager.loadMaterial("Textures/Terrain/Pond/Pond.j3m"); diff --git a/jme3-examples/src/main/java/jme3test/light/TestTwoSideLighting.java b/jme3-examples/src/main/java/jme3test/light/TestTwoSideLighting.java index e5dfdc754c..476c261ef6 100644 --- a/jme3-examples/src/main/java/jme3test/light/TestTwoSideLighting.java +++ b/jme3-examples/src/main/java/jme3test/light/TestTwoSideLighting.java @@ -44,7 +44,7 @@ import com.jme3.scene.Geometry; import com.jme3.scene.shape.Quad; import com.jme3.scene.shape.Sphere; -import com.jme3.util.TangentBinormalGenerator; +import com.jme3.util.mikktspace.MikktspaceTangentGenerator; /** * Checks two-sided lighting capability. @@ -80,7 +80,7 @@ public void simpleInitApp() { quadGeom.setMaterial(mat1); // SimpleBump material requires tangents. - TangentBinormalGenerator.generate(quadGeom); + MikktspaceTangentGenerator.generate(quadGeom); rootNode.attachChild(quadGeom); Geometry teapot = (Geometry) assetManager.loadModel("Models/Teapot/Teapot.obj"); diff --git a/jme3-examples/src/main/java/jme3test/material/TestBumpModel.java b/jme3-examples/src/main/java/jme3test/material/TestBumpModel.java index f71e43ea63..645dd074f5 100644 --- a/jme3-examples/src/main/java/jme3test/material/TestBumpModel.java +++ b/jme3-examples/src/main/java/jme3test/material/TestBumpModel.java @@ -42,7 +42,7 @@ import com.jme3.scene.Spatial; import com.jme3.scene.plugins.ogre.OgreMeshKey; import com.jme3.scene.shape.Sphere; -import com.jme3.util.TangentBinormalGenerator; +import com.jme3.util.mikktspace.MikktspaceTangentGenerator; public class TestBumpModel extends SimpleApplication { @@ -59,7 +59,7 @@ public static void main(String[] args){ public void simpleInitApp() { Spatial signpost = assetManager.loadAsset(new OgreMeshKey("Models/Sign Post/Sign Post.mesh.xml")); signpost.setMaterial(assetManager.loadMaterial("Models/Sign Post/Sign Post.j3m")); - TangentBinormalGenerator.generate(signpost); + MikktspaceTangentGenerator.generate(signpost); rootNode.attachChild(signpost); lightMdl = new Geometry("Light", new Sphere(10, 10, 0.1f)); diff --git a/jme3-examples/src/main/java/jme3test/material/TestNormalMapping.java b/jme3-examples/src/main/java/jme3test/material/TestNormalMapping.java index e75b33ba58..e8ca464d7e 100644 --- a/jme3-examples/src/main/java/jme3test/material/TestNormalMapping.java +++ b/jme3-examples/src/main/java/jme3test/material/TestNormalMapping.java @@ -41,7 +41,7 @@ import com.jme3.scene.Geometry; import com.jme3.scene.Spatial; import com.jme3.scene.shape.Sphere; -import com.jme3.util.TangentBinormalGenerator; +import com.jme3.util.mikktspace.MikktspaceTangentGenerator; public class TestNormalMapping extends SimpleApplication { @@ -59,7 +59,7 @@ public void simpleInitApp() { Sphere sphMesh = new Sphere(32, 32, 1); sphMesh.setTextureMode(Sphere.TextureMode.Projected); sphMesh.updateGeometry(32, 32, 1, false, false); - TangentBinormalGenerator.generate(sphMesh); + MikktspaceTangentGenerator.generate(sphMesh); Geometry sphere = new Geometry("Rock Ball", sphMesh); Material mat = assetManager.loadMaterial("Textures/Terrain/Pond/Pond.j3m"); diff --git a/jme3-examples/src/main/java/jme3test/material/TestParallax.java b/jme3-examples/src/main/java/jme3test/material/TestParallax.java index 80afeaf382..3715806f6d 100644 --- a/jme3-examples/src/main/java/jme3test/material/TestParallax.java +++ b/jme3-examples/src/main/java/jme3test/material/TestParallax.java @@ -44,7 +44,7 @@ import com.jme3.scene.Spatial; import com.jme3.scene.shape.RectangleMesh; import com.jme3.util.SkyFactory; -import com.jme3.util.TangentBinormalGenerator; +import com.jme3.util.mikktspace.MikktspaceTangentGenerator; public class TestParallax extends SimpleApplication { @@ -77,7 +77,7 @@ public void setupFloor() { rm.scaleTextureCoordinates(new Vector2f(10, 10)); Geometry floorGeom = new Geometry("floorGeom", rm); - TangentBinormalGenerator.generate(floorGeom); + MikktspaceTangentGenerator.generate(floorGeom); floorGeom.setMaterial(mat); rootNode.attachChild(floorGeom); @@ -86,7 +86,7 @@ public void setupFloor() { public void setupSignpost() { Spatial signpost = assetManager.loadModel("Models/Sign Post/Sign Post.mesh.xml"); Material matSp = assetManager.loadMaterial("Models/Sign Post/Sign Post.j3m"); - TangentBinormalGenerator.generate(signpost); + MikktspaceTangentGenerator.generate(signpost); signpost.setMaterial(matSp); signpost.rotate(0, FastMath.HALF_PI, 0); signpost.setLocalTranslation(12, 23.5f, 30); diff --git a/jme3-examples/src/main/java/jme3test/material/TestParallaxPBR.java b/jme3-examples/src/main/java/jme3test/material/TestParallaxPBR.java index aca2282634..038066c68b 100644 --- a/jme3-examples/src/main/java/jme3test/material/TestParallaxPBR.java +++ b/jme3-examples/src/main/java/jme3test/material/TestParallaxPBR.java @@ -44,7 +44,7 @@ import com.jme3.scene.Spatial; import com.jme3.scene.shape.RectangleMesh; import com.jme3.util.SkyFactory; -import com.jme3.util.TangentBinormalGenerator; +import com.jme3.util.mikktspace.MikktspaceTangentGenerator; public class TestParallaxPBR extends SimpleApplication { @@ -80,7 +80,7 @@ public void setupFloor() { rm.scaleTextureCoordinates(new Vector2f(10, 10)); Geometry floorGeom = new Geometry("floorGeom", rm); - TangentBinormalGenerator.generate(floorGeom); + MikktspaceTangentGenerator.generate(floorGeom); //floorGeom.setLocalScale(100); floorGeom.setMaterial(mat); @@ -90,7 +90,7 @@ public void setupFloor() { public void setupSignpost() { Spatial signpost = assetManager.loadModel("Models/Sign Post/Sign Post.mesh.xml"); Material mat = assetManager.loadMaterial("Models/Sign Post/Sign Post.j3m"); - TangentBinormalGenerator.generate(signpost); + MikktspaceTangentGenerator.generate(signpost); signpost.setMaterial(mat); signpost.rotate(0, FastMath.HALF_PI, 0); signpost.setLocalTranslation(12, 23.5f, 30); diff --git a/jme3-examples/src/main/java/jme3test/material/TestSimpleBumps.java b/jme3-examples/src/main/java/jme3test/material/TestSimpleBumps.java index 4185e1caf7..6fb1f5037f 100644 --- a/jme3-examples/src/main/java/jme3test/material/TestSimpleBumps.java +++ b/jme3-examples/src/main/java/jme3test/material/TestSimpleBumps.java @@ -42,7 +42,7 @@ import com.jme3.scene.Spatial; import com.jme3.scene.shape.Quad; import com.jme3.scene.shape.Sphere; -import com.jme3.util.TangentBinormalGenerator; +import com.jme3.util.mikktspace.MikktspaceTangentGenerator; // phong cutoff for light to normal angle > 90? public class TestSimpleBumps extends SimpleApplication { @@ -63,7 +63,7 @@ public void simpleInitApp() { Geometry sphere = new Geometry("Rock Ball", quadMesh); Material mat = assetManager.loadMaterial("Textures/BumpMapTest/SimpleBump.j3m"); sphere.setMaterial(mat); - TangentBinormalGenerator.generate(sphere); + MikktspaceTangentGenerator.generate(sphere); rootNode.attachChild(sphere); lightMdl = new Geometry("Light", new Sphere(10, 10, 0.1f)); diff --git a/jme3-examples/src/main/java/jme3test/material/TestUnshadedModel.java b/jme3-examples/src/main/java/jme3test/material/TestUnshadedModel.java index 826ef448d0..659a447a48 100644 --- a/jme3-examples/src/main/java/jme3test/material/TestUnshadedModel.java +++ b/jme3-examples/src/main/java/jme3test/material/TestUnshadedModel.java @@ -8,7 +8,7 @@ import com.jme3.math.Vector3f; import com.jme3.scene.Geometry; import com.jme3.scene.shape.Sphere; -import com.jme3.util.TangentBinormalGenerator; +import com.jme3.util.mikktspace.MikktspaceTangentGenerator; public class TestUnshadedModel extends SimpleApplication { @@ -22,7 +22,7 @@ public void simpleInitApp() { Sphere sphMesh = new Sphere(32, 32, 1); sphMesh.setTextureMode(Sphere.TextureMode.Projected); sphMesh.updateGeometry(32, 32, 1, false, false); - TangentBinormalGenerator.generate(sphMesh); + MikktspaceTangentGenerator.generate(sphMesh); Geometry sphere = new Geometry("Rock Ball", sphMesh); Material mat = assetManager.loadMaterial("Textures/Terrain/Pond/Pond.j3m"); diff --git a/jme3-examples/src/main/java/jme3test/model/anim/TestAnimationFactory.java b/jme3-examples/src/main/java/jme3test/model/anim/TestAnimationFactory.java index e09500e248..602b88d04a 100644 --- a/jme3-examples/src/main/java/jme3test/model/anim/TestAnimationFactory.java +++ b/jme3-examples/src/main/java/jme3test/model/anim/TestAnimationFactory.java @@ -12,7 +12,7 @@ import com.jme3.scene.Geometry; import com.jme3.scene.Node; import com.jme3.scene.shape.Box; -import com.jme3.util.TangentBinormalGenerator; +import com.jme3.util.mikktspace.MikktspaceTangentGenerator; public class TestAnimationFactory extends SimpleApplication { @@ -45,7 +45,7 @@ public void simpleInitApp() { childModel.setLocalTranslation(2, 2, 2); childModel.attachChild(childGeom); model.attachChild(childModel); - TangentBinormalGenerator.generate(model); + MikktspaceTangentGenerator.generate(model); // Construct a complex animation using AnimFactory: // 6 seconds in duration, named "anim", running at 25 frames per second diff --git a/jme3-examples/src/main/java/jme3test/post/TestLightScattering.java b/jme3-examples/src/main/java/jme3test/post/TestLightScattering.java index c2940cab6b..83e0d464e8 100644 --- a/jme3-examples/src/main/java/jme3test/post/TestLightScattering.java +++ b/jme3-examples/src/main/java/jme3test/post/TestLightScattering.java @@ -45,7 +45,7 @@ import com.jme3.scene.Node; import com.jme3.scene.Spatial; import com.jme3.util.SkyFactory; -import com.jme3.util.TangentBinormalGenerator; +import com.jme3.util.mikktspace.MikktspaceTangentGenerator; public class TestLightScattering extends SimpleApplication { @@ -66,7 +66,7 @@ public void simpleInitApp() { flyCam.setMoveSpeed(10); Material mat = assetManager.loadMaterial("Textures/Terrain/Rocky/Rocky.j3m"); Spatial scene = assetManager.loadModel("Models/Terrain/Terrain.mesh.xml"); - TangentBinormalGenerator.generate(((Geometry)((Node)scene).getChild(0)).getMesh()); + MikktspaceTangentGenerator.generate(((Geometry) ((Node) scene).getChild(0)).getMesh()); scene.setMaterial(mat); scene.setShadowMode(ShadowMode.CastAndReceive); scene.setLocalScale(400); diff --git a/jme3-examples/src/main/java/jme3test/post/TestPostFilters.java b/jme3-examples/src/main/java/jme3test/post/TestPostFilters.java index b7f6658ce7..a46b14655c 100644 --- a/jme3-examples/src/main/java/jme3test/post/TestPostFilters.java +++ b/jme3-examples/src/main/java/jme3test/post/TestPostFilters.java @@ -48,7 +48,7 @@ import com.jme3.texture.Texture; import com.jme3.util.SkyFactory; import com.jme3.util.SkyFactory.EnvMapType; -import com.jme3.util.TangentBinormalGenerator; +import com.jme3.util.mikktspace.MikktspaceTangentGenerator; public class TestPostFilters extends SimpleApplication implements ActionListener { @@ -111,7 +111,7 @@ public void setupLighting() { public void setupFloor() { Material mat = assetManager.loadMaterial("Textures/Terrain/BrickWall/BrickWall.j3m"); Box floor = new Box(50, 1f, 50); - TangentBinormalGenerator.generate(floor); + MikktspaceTangentGenerator.generate(floor); floor.scaleTextureCoordinates(new Vector2f(5, 5)); Geometry floorGeom = new Geometry("Floor", floor); floorGeom.setMaterial(mat); diff --git a/jme3-examples/src/main/java/jme3test/post/TestTransparentSSAO.java b/jme3-examples/src/main/java/jme3test/post/TestTransparentSSAO.java index 6694454a9b..241796d444 100644 --- a/jme3-examples/src/main/java/jme3test/post/TestTransparentSSAO.java +++ b/jme3-examples/src/main/java/jme3test/post/TestTransparentSSAO.java @@ -12,7 +12,7 @@ import com.jme3.scene.Geometry; import com.jme3.scene.Spatial; import com.jme3.scene.shape.RectangleMesh; -import com.jme3.util.TangentBinormalGenerator; +import com.jme3.util.mikktspace.MikktspaceTangentGenerator; public class TestTransparentSSAO extends SimpleApplication { @@ -42,7 +42,7 @@ public void simpleInitApp() { geom.setMaterial(mat); geom.setShadowMode(ShadowMode.Receive); - TangentBinormalGenerator.generate(geom); + MikktspaceTangentGenerator.generate(geom); rootNode.attachChild(geom); // create the geometry and attach it diff --git a/jme3-terrain/src/main/java/com/jme3/terrain/geomipmap/TerrainQuad.java b/jme3-terrain/src/main/java/com/jme3/terrain/geomipmap/TerrainQuad.java index 8331bfd578..3e3b6a84ee 100644 --- a/jme3-terrain/src/main/java/com/jme3/terrain/geomipmap/TerrainQuad.java +++ b/jme3-terrain/src/main/java/com/jme3/terrain/geomipmap/TerrainQuad.java @@ -56,7 +56,7 @@ import com.jme3.terrain.geomipmap.picking.BresenhamTerrainPicker; import com.jme3.terrain.geomipmap.picking.TerrainPickData; import com.jme3.terrain.geomipmap.picking.TerrainPicker; -import com.jme3.util.TangentBinormalGenerator; +import com.jme3.util.TangentUtils; import com.jme3.util.clone.Cloner; import java.io.IOException; import java.util.ArrayList; @@ -677,7 +677,7 @@ public void generateDebugTangents(Material mat) { ((TerrainQuad)child).generateDebugTangents(mat); } else if (child instanceof TerrainPatch) { Geometry debug = new Geometry( "Debug " + name, - TangentBinormalGenerator.genTbnLines( ((TerrainPatch)child).getMesh(), 0.8f)); + TangentUtils.genTbnLines(((TerrainPatch) child).getMesh(), 0.8f)); attachChild(debug); debug.setLocalTranslation(child.getLocalTranslation()); debug.setCullHint(CullHint.Never); From 3f1795682b7f0e081faec6ec2af1d07d658d2dfa Mon Sep 17 00:00:00 2001 From: Riccardo Balbo Date: Thu, 9 Nov 2023 18:57:38 +0100 Subject: [PATCH 5/6] Add patch to supported mesh types --- .../com/jme3/util/mikktspace/MikktspaceTangentGenerator.java | 1 + 1 file changed, 1 insertion(+) diff --git a/jme3-core/src/main/java/com/jme3/util/mikktspace/MikktspaceTangentGenerator.java b/jme3-core/src/main/java/com/jme3/util/mikktspace/MikktspaceTangentGenerator.java index 49792fb396..8d17b864f9 100644 --- a/jme3-core/src/main/java/com/jme3/util/mikktspace/MikktspaceTangentGenerator.java +++ b/jme3-core/src/main/java/com/jme3/util/mikktspace/MikktspaceTangentGenerator.java @@ -140,6 +140,7 @@ private static boolean generateTangents(Mesh mesh) { case Triangles: case TriangleFan: case TriangleStrip: + case Patch: hasTriangles = true; break; From 32d37eff5707f0eb41f46b7e71bf7ed4047040ac Mon Sep 17 00:00:00 2001 From: Riccardo Balbo Date: Thu, 9 Nov 2023 21:20:49 +0100 Subject: [PATCH 6/6] Fix --- .../src/main/java/jme3test/light/TestTangentGenBadUV.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/jme3-examples/src/main/java/jme3test/light/TestTangentGenBadUV.java b/jme3-examples/src/main/java/jme3test/light/TestTangentGenBadUV.java index 6d1e937631..e791d30889 100644 --- a/jme3-examples/src/main/java/jme3test/light/TestTangentGenBadUV.java +++ b/jme3-examples/src/main/java/jme3test/light/TestTangentGenBadUV.java @@ -42,6 +42,7 @@ import com.jme3.scene.Geometry; import com.jme3.scene.Spatial; import com.jme3.scene.shape.Sphere; +import com.jme3.util.TangentUtils; import com.jme3.util.mikktspace.MikktspaceTangentGenerator; public class TestTangentGenBadUV extends SimpleApplication { @@ -71,7 +72,7 @@ public void simpleInitApp() { Geometry debug = new Geometry( "Debug Teapot", - MikktspaceTangentGenerator.genTbnLines(((Geometry) teapot).getMesh(), 0.03f) + TangentUtils.genTbnLines(((Geometry) teapot).getMesh(), 0.03f) ); Material debugMat = assetManager.loadMaterial("Common/Materials/VertexColor.j3m"); debug.setMaterial(debugMat);