Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comparison methods for BoundingBox and BoundingSphere #2249

Closed
stephengold opened this issue Apr 24, 2024 · 0 comments · Fixed by #2252
Closed

comparison methods for BoundingBox and BoundingSphere #2249

stephengold opened this issue Apr 24, 2024 · 0 comments · Fixed by #2252
Assignees
@stephengold
Labels
enhancement
Milestone
v3.7.0

Comments

@stephengold
Copy link
Member

Currently if you invoke equals() on a BoundingBox or BoundingSphere you get Object.equals(), which ignores the object's components. Usually that isn't what's desired.

By analogy with com.jme3.math classes such as Matrix4f, Quaternion, and Vector3f, these 2 classes should:

  • override the equals() method to test for precise equality of all components (distinguishing -0 from 0) AND
  • provide an isSimilar() method to test for approximate equality of all components.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephengold stephengold

Labels
enhancement
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging a pull request may close this issue.

implement equals(), hashCode(), and isSimilar() for bounding volumes jMonkeyEngine/jmonkeyengine
1 participant
@stephengold