Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typings #104

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add typings #104

wants to merge 5 commits into from

Conversation

EgeOnder
Copy link

This pull request aims to fix #92 by adding new TypeScript typings to the library. I was trying to use the library with TypeScript when I realized there is no support for it. So I decided to implement new types for my project. This was for personal use only, decided to PR. ✨

Don't be afraid to criticize and please give constructive feedback, thank you!

@EgeOnder EgeOnder marked this pull request as draft September 14, 2022 12:03
@ardauzan
Copy link

Selam, neden draft a aldiniz?

@EgeOnder
Copy link
Author

EgeOnder commented Nov 2, 2022

Son versiyonun 3 yıl önce paylaşıldığı ve CI Pipeline'larında Node 3, 4, 5 bulunan bir kütüphaneye katkıda bulunmak biraz zor oluyor. Travis testlerini geçemeyeceğinden fazla uğraşmayı tercih etmedim. En son kullandığım halini paylaşıp bırakacağım.

@EgeOnder EgeOnder marked this pull request as ready for review November 3, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript types
5 participants