Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Dark mode #29

Closed
thebergamo opened this issue Aug 20, 2024 · 7 comments
Closed

Support Dark mode #29

thebergamo opened this issue Aug 20, 2024 · 7 comments

Comments

@thebergamo
Copy link

thebergamo commented Aug 20, 2024

This project is really amazing and it's helping me a bunch to get started with some ideas!
I was just wondering if the dark mode is not supported out of the box to support the pro version or you would be open once I manage to fix it to file a PR with such support?

@ixartz
Copy link
Owner

ixartz commented Aug 20, 2024

Hi @thebergamo,

Thank you so much for your comment and thank you for your help. All support is welcomed.

Yes, unfortunately, the dark mode isn't supported out of the box yet but I'm planning to do it. Because the project is using Shadcn UI, it shouldn't be a big issue to implement it.
If you manage to implement a dark mode, I would love to review your PR and merge it if it's working perfectly.

Again thank you so much.

@thebergamo
Copy link
Author

I kind of manage already to do it, but there is something that bugs me still.
The only way I manage to support it is using @media (prefers-color-scheme: dark) rather than the regular .dark from out of the box Shadcn UI. If that's fine for you I can do the PR for testing :)

@ixartz
Copy link
Owner

ixartz commented Aug 20, 2024

Any reason it didn't work with the regular .dark from out of the box Shadcn UI? It would be great to keep the same logic as the Shadcn UI. What is the blocker to use the .dark feature from Shadcn UI?

@thebergamo
Copy link
Author

I tried to understand, but didn't managed to grasp the why. In general in all my project it usually works fine, but for some reason in this one the .dark from the global.css it got striped and wasn't in the layout.css file

@ixartz
Copy link
Owner

ixartz commented Aug 20, 2024

I won't be surprise I misconfigured somewhere, it's the first time I'm playing with Shadcn UI.

@ixartz
Copy link
Owner

ixartz commented Oct 11, 2024

@ixartz
Copy link
Owner

ixartz commented Oct 15, 2024

Just implement and release a dark mode, you can find a live demo at: https://pro-demo.nextjs-boilerplate.com

@ixartz ixartz closed this as completed Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants