Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async-io dependency breaks build #7

Closed
FrozenDroid opened this issue Aug 16, 2023 · 4 comments
Closed

async-io dependency breaks build #7

FrozenDroid opened this issue Aug 16, 2023 · 4 comments

Comments

@FrozenDroid
Copy link

Quite easy to reproduce - just build master and you will see many errors involving libc.

@FrozenDroid
Copy link
Author

[patch.crates-io]
async-io = { git = "https://github.com/smol-rs/async-io.git", rev = "d9c9ed8" }
socket2 = { git = "https://github.com/rust-lang/socket2", rev = "77e3bb9" }

seems to fix my issue - I suppose we need to wait for async-io and socket2 to release new versions to fix this.

@ivmarkov
Copy link
Owner

ivmarkov commented Aug 16, 2023

Upstream support for ESP IDF in the smol ecosystem is in an odd shape right now:

We need new releases for the following crates, as the ESP IDF changes are upstreamed in there, but not released yet:

  • socket2
  • polling
  • rust-errno

Crates where the ESP IDF changes are upstreamed and also released:

  • rustix

Crates where ESP IDF changes are upstreamed, yet their master branch is not usable yet:

  • async-io, because of this

In the meantime, what you can do is:

  • pin async-io to an old version as done here and here
  • Patch polling and socket2 (and possibly, the smol aggregation crate itself) as done here to earlier not upstreamed forks. also done here

UPDATE:

Crates which still need a small PR to be upstreamed:

  • smol, here. No big deal as smol is just an aggregator crate anyway.

@ivmarkov
Copy link
Owner

ivmarkov commented Oct 1, 2023

@FrozenDroid Small progress update:

  • polling 3.0 was released recently, with all ESP-IDF-related changes upstreamed
  • The relevant ESP-IDF changes to rustix,socket2 and errno are also upstreamed and released.

Waiting for the release of async-io 2.0 now, which I hope is imminent, and which would probably be released together with smol 2.0.

That would complete the upstreaming story of ESP-IDF in the smol-rs echosystem.

@ivmarkov
Copy link
Owner

d96b37b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants