Skip to content

Commit 95373db

Browse files
singalsukv2019i
authored andcommitted
Arch: host: Cleanup mixer vs. mixin/mixout component build
The build of mixin/mixout didn't work for static library IPC4 testbench build because Kconfig for mixer has "depends on IPC_MAJOR_3". Therefore the if(CONFIG_COMP_MIXER) with IPC version dependent sources was never true. It's replaced with normal component build handling for CONFIG_COMP_MIXER and CONFIG_COMP_MIXIN_MIXOUT. The confusing looking "set(mixer_src ..." from begin of CMakeLists.txt is moved to end where shared libraries of audio modules are built. The default configuration of SOF plugin is changed to CONFIG_COMP_MIXIN_MIXOUT=y to make sure the correct mixer is built for it. Signed-off-by: Seppo Ingalsuo <[email protected]>
1 parent eaddf53 commit 95373db

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

src/arch/host/configs/plugin_ipc4_defconfig

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ CONFIG_COMP_GAIN=y
1212
CONFIG_COMP_VOLUME_WINDOWS_FADE=y
1313
CONFIG_COMP_MODULES_SO=y
1414
CONFIG_COMP_MODULE_ADAPTER=y
15-
CONFIG_COMP_MIXER=y
15+
CONFIG_COMP_MIXIN_MIXOUT=y
1616
CONFIG_IPC4_GATEWAY=n
1717
CONFIG_COMP_DAI_GROUP=n
1818
CONFIG_FORMAT_S16LE=y

src/audio/CMakeLists.txt

+11-9
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
# SPDX-License-Identifier: BSD-3-Clause
22

3-
if(CONFIG_IPC_MAJOR_3)
4-
set(mixer_src mixer/mixer.c mixer/mixer_generic.c mixer/mixer_hifi3.c)
5-
elseif(CONFIG_IPC_MAJOR_4)
6-
set(mixer_src mixin_mixout/mixin_mixout.c mixin_mixout/mixin_mixout_generic.c mixin_mixout/mixin_mixout_hifi3.c)
7-
endif()
8-
93
if(NOT CONFIG_COMP_MODULE_SHARED_LIBRARY_BUILD)
104
add_local_sources(sof
115
host-legacy.c
@@ -52,9 +46,10 @@ if(NOT CONFIG_COMP_MODULE_SHARED_LIBRARY_BUILD)
5246
)
5347
endif()
5448
if(CONFIG_COMP_MIXER)
55-
add_local_sources(sof
56-
${mixer_src}
57-
)
49+
add_subdirectory(mixer)
50+
endif()
51+
if(CONFIG_COMP_MIXIN_MIXOUT)
52+
add_subdirectory(mixin_mixout)
5853
endif()
5954
if(CONFIG_COMP_MUX)
6055
add_subdirectory(mux)
@@ -200,6 +195,13 @@ elseif(CONFIG_IPC_MAJOR_4)
200195
set(mux_sources mux/mux_ipc4.c)
201196
set(crossover_sources crossover/crossover_ipc4.c)
202197
endif()
198+
199+
if(CONFIG_IPC_MAJOR_3)
200+
set(mixer_src mixer/mixer.c mixer/mixer_generic.c mixer/mixer_hifi3.c)
201+
elseif(CONFIG_IPC_MAJOR_4)
202+
set(mixer_src mixin_mixout/mixin_mixout.c mixin_mixout/mixin_mixout_generic.c mixin_mixout/mixin_mixout_hifi3.c)
203+
endif()
204+
203205
set(mixer_sources ${mixer_src})
204206
set(asrc_sources asrc/asrc.c asrc/asrc_farrow.c asrc/asrc_farrow_generic.c)
205207
set(eq-fir_sources eq_fir/eq_fir.c eq_fir/eq_fir_generic.c)

0 commit comments

Comments
 (0)