We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi, apparently informative_X_indicators() are practically identical and could be refactored to a unique informative_indicators().
Then only changing info_switcher could be enough:
def info_switcher(self, metadata: dict, info_timeframe) -> DataFrame: if info_timeframe == "1d": return self.informative_1d_indicators(metadata, info_timeframe) elif info_timeframe == "4h": return self.informative_4h_indicators(metadata, info_timeframe) elif info_timeframe == "1h": return self.informative_1h_indicators(metadata, info_timeframe) elif info_timeframe == "15m": return self.informative_15m_indicators(metadata, info_timeframe) else: raise RuntimeError(f"{info_timeframe} not supported as informative timeframe for BTC pair.")
to
def info_switcher(self, metadata: dict, info_timeframe) -> DataFrame: if info_timeframe in ["1d", "4h", "1h", "15m"]: return self.informative_indicators(metadata, info_timeframe) else: raise RuntimeError(f"{info_timeframe} not supported as informative timeframe for BTC pair.")
The text was updated successfully, but these errors were encountered:
If you think it's ok I can do a PR
Sorry, something went wrong.
Hi, sure thing, thanks !
No branches or pull requests
Hi, apparently informative_X_indicators() are practically identical and could be refactored to a unique informative_indicators().
Then only changing info_switcher could be enough:
to
The text was updated successfully, but these errors were encountered: