Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CryptoService - review null handling #637

Open
MrSebastian opened this issue Dec 11, 2024 · 0 comments
Open

CryptoService - review null handling #637

MrSebastian opened this issue Dec 11, 2024 · 0 comments

Comments

@MrSebastian
Copy link
Member

          _:warning: Potential issue_

Review null handling implementation

The test expects null input to be concatenated with the prefix (ENCRYPTION_PREFIX + null), which seems incorrect. Typically, null inputs should either:

  1. Throw an IllegalArgumentException
  2. Return just the prefix
  3. Return null

Please verify the intended behavior.

Originally posted by @coderabbitai[bot] in #635 (comment)

@MrSebastian MrSebastian changed the title CryptoService - review nul handling CryptoService - review nuöl handling Dec 11, 2024
@MrSebastian MrSebastian changed the title CryptoService - review nuöl handling CryptoService - review null handling Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant