From 2ec614c7bbfde428e0a0a04d84ae3e814893cd9e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Istv=C3=A1n=20So=C3=B3s?= Date: Thu, 7 Dec 2023 18:37:43 +0100 Subject: [PATCH] Title and accessible label for search input fields. (#7261) --- app/lib/frontend/templates/views/shared/search_banner.dart | 4 ++++ app/lib/frontend/templates/views/shared/site_header.dart | 4 ++++ app/test/frontend/golden/authorized_page.html | 2 +- app/test/frontend/golden/consent_page.html | 2 +- app/test/frontend/golden/create_publisher_page.html | 2 +- app/test/frontend/golden/error_page.html | 2 +- app/test/frontend/golden/help_page.html | 2 +- app/test/frontend/golden/landing_page.html | 2 +- app/test/frontend/golden/my_activity_log_page.html | 2 +- app/test/frontend/golden/my_liked_packages.html | 2 +- app/test/frontend/golden/my_packages.html | 2 +- app/test/frontend/golden/my_publishers.html | 2 +- app/test/frontend/golden/pkg_activity_log_page.html | 2 +- app/test/frontend/golden/pkg_admin_page.html | 2 +- app/test/frontend/golden/pkg_changelog_page.html | 2 +- app/test/frontend/golden/pkg_example_page.html | 2 +- app/test/frontend/golden/pkg_index_page.html | 2 +- app/test/frontend/golden/pkg_install_page.html | 2 +- app/test/frontend/golden/pkg_score_page.html | 2 +- app/test/frontend/golden/pkg_show_page.html | 2 +- app/test/frontend/golden/pkg_show_page_discontinued.html | 2 +- app/test/frontend/golden/pkg_show_page_flutter_plugin.html | 2 +- app/test/frontend/golden/pkg_show_page_publisher.html | 2 +- app/test/frontend/golden/pkg_show_page_retracted.html | 2 +- .../golden/pkg_show_page_retracted_non_retracted_version.html | 2 +- app/test/frontend/golden/pkg_show_version_page.html | 2 +- app/test/frontend/golden/pkg_versions_page.html | 2 +- app/test/frontend/golden/publisher_activity_log_page.html | 2 +- app/test/frontend/golden/publisher_admin_page.html | 2 +- app/test/frontend/golden/publisher_list_page.html | 2 +- app/test/frontend/golden/publisher_packages_page.html | 2 +- .../frontend/golden/publisher_unlisted_packages_page.html | 2 +- app/test/frontend/golden/search_page.html | 2 +- app/test/frontend/golden/topics_page.html | 2 +- app/test/task/testdata/goldens/packages/oxygen.html | 2 +- app/test/task/testdata/goldens/packages/oxygen/changelog.html | 2 +- app/test/task/testdata/goldens/packages/oxygen/example.html | 2 +- app/test/task/testdata/goldens/packages/oxygen/install.html | 2 +- app/test/task/testdata/goldens/packages/oxygen/license.html | 2 +- app/test/task/testdata/goldens/packages/oxygen/score.html | 2 +- app/test/task/testdata/goldens/packages/oxygen/versions.html | 2 +- .../task/testdata/goldens/packages/oxygen/versions/1.0.0.html | 2 +- .../goldens/packages/oxygen/versions/1.0.0/changelog.html | 2 +- .../goldens/packages/oxygen/versions/1.0.0/example.html | 2 +- .../goldens/packages/oxygen/versions/1.0.0/install.html | 2 +- .../goldens/packages/oxygen/versions/1.0.0/license.html | 2 +- .../goldens/packages/oxygen/versions/1.0.0/score.html | 2 +- .../task/testdata/goldens/packages/oxygen/versions/2.0.0.html | 2 +- 48 files changed, 54 insertions(+), 46 deletions(-) diff --git a/app/lib/frontend/templates/views/shared/search_banner.dart b/app/lib/frontend/templates/views/shared/search_banner.dart index 61849b0d90..db5cb9f4ee 100644 --- a/app/lib/frontend/templates/views/shared/search_banner.dart +++ b/app/lib/frontend/templates/views/shared/search_banner.dart @@ -25,6 +25,10 @@ d.Node searchBannerNode({ autocomplete: 'on', autofocus: autofocus, value: queryText, + attributes: { + 'title': 'Search', + 'aria-label': 'Search', + }, ), d.button(classes: ['icon'], ariaLabel: 'search'), if (showSearchFiltersButton) diff --git a/app/lib/frontend/templates/views/shared/site_header.dart b/app/lib/frontend/templates/views/shared/site_header.dart index 2fda58d802..df8742c38c 100644 --- a/app/lib/frontend/templates/views/shared/site_header.dart +++ b/app/lib/frontend/templates/views/shared/site_header.dart @@ -44,6 +44,10 @@ d.Node siteHeaderNode({ name: 'q', placeholder: 'New search...', autocomplete: 'on', + attributes: { + 'title': 'Search', + 'aria-label': 'Search', + }, ), ), ), diff --git a/app/test/frontend/golden/authorized_page.html b/app/test/frontend/golden/authorized_page.html index 0c61e84a4d..15962b2f71 100644 --- a/app/test/frontend/golden/authorized_page.html +++ b/app/test/frontend/golden/authorized_page.html @@ -41,7 +41,7 @@
diff --git a/app/test/frontend/golden/consent_page.html b/app/test/frontend/golden/consent_page.html index 44cfe65d4c..8aee21eaf0 100644 --- a/app/test/frontend/golden/consent_page.html +++ b/app/test/frontend/golden/consent_page.html @@ -41,7 +41,7 @@
diff --git a/app/test/frontend/golden/create_publisher_page.html b/app/test/frontend/golden/create_publisher_page.html index 07887ea7db..df6abf22a0 100644 --- a/app/test/frontend/golden/create_publisher_page.html +++ b/app/test/frontend/golden/create_publisher_page.html @@ -40,7 +40,7 @@
diff --git a/app/test/frontend/golden/error_page.html b/app/test/frontend/golden/error_page.html index 074358d0f6..18f0786511 100644 --- a/app/test/frontend/golden/error_page.html +++ b/app/test/frontend/golden/error_page.html @@ -102,7 +102,7 @@

diff --git a/app/test/frontend/golden/help_page.html b/app/test/frontend/golden/help_page.html index 6c1163e705..08b2929dfd 100644 --- a/app/test/frontend/golden/help_page.html +++ b/app/test/frontend/golden/help_page.html @@ -41,7 +41,7 @@
diff --git a/app/test/frontend/golden/landing_page.html b/app/test/frontend/golden/landing_page.html index 5d91c1c4a3..11b5993229 100644 --- a/app/test/frontend/golden/landing_page.html +++ b/app/test/frontend/golden/landing_page.html @@ -104,7 +104,7 @@

pub.dev package manager

diff --git a/app/test/frontend/golden/my_activity_log_page.html b/app/test/frontend/golden/my_activity_log_page.html index 27ef4b9cd0..64d84460a5 100644 --- a/app/test/frontend/golden/my_activity_log_page.html +++ b/app/test/frontend/golden/my_activity_log_page.html @@ -41,7 +41,7 @@

diff --git a/app/test/frontend/golden/my_liked_packages.html b/app/test/frontend/golden/my_liked_packages.html index 894cb22c63..1632f51ce8 100644 --- a/app/test/frontend/golden/my_liked_packages.html +++ b/app/test/frontend/golden/my_liked_packages.html @@ -42,7 +42,7 @@
diff --git a/app/test/frontend/golden/my_packages.html b/app/test/frontend/golden/my_packages.html index b5fc1a4328..7c0a0f7b10 100644 --- a/app/test/frontend/golden/my_packages.html +++ b/app/test/frontend/golden/my_packages.html @@ -41,7 +41,7 @@
diff --git a/app/test/frontend/golden/my_publishers.html b/app/test/frontend/golden/my_publishers.html index 9a4d8bad8d..51da3494cd 100644 --- a/app/test/frontend/golden/my_publishers.html +++ b/app/test/frontend/golden/my_publishers.html @@ -41,7 +41,7 @@
diff --git a/app/test/frontend/golden/pkg_activity_log_page.html b/app/test/frontend/golden/pkg_activity_log_page.html index bf8e497008..d6b795f82b 100644 --- a/app/test/frontend/golden/pkg_activity_log_page.html +++ b/app/test/frontend/golden/pkg_activity_log_page.html @@ -43,7 +43,7 @@
diff --git a/app/test/frontend/golden/pkg_admin_page.html b/app/test/frontend/golden/pkg_admin_page.html index aa511c3b94..887c61848e 100644 --- a/app/test/frontend/golden/pkg_admin_page.html +++ b/app/test/frontend/golden/pkg_admin_page.html @@ -43,7 +43,7 @@
diff --git a/app/test/frontend/golden/pkg_changelog_page.html b/app/test/frontend/golden/pkg_changelog_page.html index bf6da56c1d..64e6c99ec8 100644 --- a/app/test/frontend/golden/pkg_changelog_page.html +++ b/app/test/frontend/golden/pkg_changelog_page.html @@ -43,7 +43,7 @@
diff --git a/app/test/frontend/golden/pkg_example_page.html b/app/test/frontend/golden/pkg_example_page.html index ddc820f12e..600b59c24b 100644 --- a/app/test/frontend/golden/pkg_example_page.html +++ b/app/test/frontend/golden/pkg_example_page.html @@ -43,7 +43,7 @@
diff --git a/app/test/frontend/golden/pkg_index_page.html b/app/test/frontend/golden/pkg_index_page.html index 9cca9c26de..77ada6ddaa 100644 --- a/app/test/frontend/golden/pkg_index_page.html +++ b/app/test/frontend/golden/pkg_index_page.html @@ -103,7 +103,7 @@