From 240ab3e946288df305c050da7ce6a64b2cfd887d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Istv=C3=A1n=20So=C3=B3s?= Date: Tue, 2 Jan 2024 11:55:55 +0100 Subject: [PATCH] keyboard support for screenshot carrousel (#7333) --- .../templates/views/pkg/screenshots.dart | 5 ++ app/test/frontend/golden/my_packages.html | 4 +- .../golden/pkg_activity_log_page.html | 8 +- app/test/frontend/golden/pkg_admin_page.html | 8 +- .../frontend/golden/pkg_changelog_page.html | 8 +- .../frontend/golden/pkg_example_page.html | 8 +- app/test/frontend/golden/pkg_index_page.html | 4 +- .../frontend/golden/pkg_install_page.html | 8 +- app/test/frontend/golden/pkg_score_page.html | 8 +- app/test/frontend/golden/pkg_show_page.html | 8 +- .../golden/pkg_show_page_discontinued.html | 8 +- .../golden/pkg_show_page_flutter_plugin.html | 8 +- .../golden/pkg_show_page_publisher.html | 8 +- .../golden/pkg_show_page_retracted.html | 8 +- ..._page_retracted_non_retracted_version.html | 8 +- .../golden/pkg_show_version_page.html | 8 +- .../frontend/golden/pkg_versions_page.html | 8 +- .../golden/publisher_packages_page.html | 4 +- .../publisher_unlisted_packages_page.html | 4 +- app/test/frontend/golden/search_page.html | 4 +- app/test/frontend/static_files_test.dart | 2 +- .../testdata/goldens/packages/oxygen.html | 12 +-- .../goldens/packages/oxygen/changelog.html | 12 +-- .../goldens/packages/oxygen/example.html | 12 +-- .../goldens/packages/oxygen/install.html | 12 +-- .../goldens/packages/oxygen/license.html | 12 +-- .../goldens/packages/oxygen/score.html | 12 +-- .../goldens/packages/oxygen/versions.html | 12 +-- .../packages/oxygen/versions/1.0.0.html | 12 +-- .../oxygen/versions/1.0.0/changelog.html | 12 +-- .../oxygen/versions/1.0.0/example.html | 12 +-- .../oxygen/versions/1.0.0/install.html | 12 +-- .../oxygen/versions/1.0.0/license.html | 12 +-- .../packages/oxygen/versions/1.0.0/score.html | 12 +-- .../packages/oxygen/versions/2.0.0.html | 12 +-- pkg/web_app/lib/src/_dom_helper.dart | 36 +++++--- pkg/web_app/lib/src/screenshot_carousel.dart | 87 ++++++++++++++++--- 37 files changed, 255 insertions(+), 175 deletions(-) diff --git a/app/lib/frontend/templates/views/pkg/screenshots.dart b/app/lib/frontend/templates/views/pkg/screenshots.dart index 27ded9366b..e7979bea9f 100644 --- a/app/lib/frontend/templates/views/pkg/screenshots.dart +++ b/app/lib/frontend/templates/views/pkg/screenshots.dart @@ -27,6 +27,7 @@ d.Node imageCarousel() { attributes: { 'title': 'Next', 'data-ga-click-event': 'screenshot-carousel-next-click', + 'tabindex': '0', }); final prev = material.floatingActionButton( @@ -43,6 +44,7 @@ d.Node imageCarousel() { attributes: { 'title': 'Previous', 'data-ga-click-event': 'screenshot-carousel-prev-click', + 'tabindex': '0', }); final description = @@ -81,6 +83,9 @@ d.Node screenshotThumbnailNode({ image: d.Image( alt: 'screenshot', width: null, height: null, src: thumbnailUrl), title: 'View screenshots', + attributes: { + 'tabindex': '0', + }, ), ]); } diff --git a/app/test/frontend/golden/my_packages.html b/app/test/frontend/golden/my_packages.html index ea2524eccc..ebb6abeb9e 100644 --- a/app/test/frontend/golden/my_packages.html +++ b/app/test/frontend/golden/my_packages.html @@ -330,12 +330,12 @@

- +
- +
diff --git a/app/test/frontend/golden/pkg_activity_log_page.html b/app/test/frontend/golden/pkg_activity_log_page.html index 5525b34209..cc36505154 100644 --- a/app/test/frontend/golden/pkg_activity_log_page.html +++ b/app/test/frontend/golden/pkg_activity_log_page.html @@ -339,12 +339,12 @@

Metadata