From 127f6fcc643d9e7cf6b36835ec0f491faae7a8ba Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Istv=C3=A1n=20So=C3=B3s?= <isoos@users.noreply.github.com>
Date: Tue, 14 Jan 2025 16:15:18 +0100
Subject: [PATCH] Remove unconditional placeholder from dartdoc page rendering.
 (#8465)

---
 app/lib/dartdoc/dartdoc_page.dart                          | 3 ---
 app/test/dartdoc/dartdoc_page_test.dart                    | 7 -------
 .../testdata/goldens/documentation/oxygen/1.0.0/index.html | 1 -
 .../goldens/documentation/oxygen/1.0.0/oxygen/index.html   | 1 -
 .../testdata/goldens/documentation/oxygen/2.0.0/index.html | 1 -
 .../goldens/documentation/oxygen/2.0.0/oxygen/index.html   | 1 -
 .../goldens/documentation/oxygen/latest/index.html         | 1 -
 .../goldens/documentation/oxygen/latest/oxygen/index.html  | 1 -
 8 files changed, 16 deletions(-)

diff --git a/app/lib/dartdoc/dartdoc_page.dart b/app/lib/dartdoc/dartdoc_page.dart
index 52812e1758..2764b465ff 100644
--- a/app/lib/dartdoc/dartdoc_page.dart
+++ b/app/lib/dartdoc/dartdoc_page.dart
@@ -254,9 +254,6 @@ extension DartDocPageRender on DartDocPage {
             ],
           ),
           _left,
-          // TODO: remove this after all runtimes are rendered with dartdoc >=8.0.0
-          if (!left.contains('dartdoc-sidebar-left-content'))
-            d.div(id: 'dartdoc-sidebar-left-content', text: ''),
         ],
       );
 
diff --git a/app/test/dartdoc/dartdoc_page_test.dart b/app/test/dartdoc/dartdoc_page_test.dart
index 23e52b1312..3cd7a479b8 100644
--- a/app/test/dartdoc/dartdoc_page_test.dart
+++ b/app/test/dartdoc/dartdoc_page_test.dart
@@ -224,13 +224,6 @@ void main() {
               renderedFirstBreadcrumbs.remove();
             }
 
-            // removing unconditional placeholder
-            renderedXmlDoc.descendantElements
-                .firstWhereOrNull((e) =>
-                    e.localName == 'div' &&
-                    e.getAttribute('id') == 'dartdoc-sidebar-left-content')
-                ?.remove();
-
             // main content section -> div
             final fileMainContentDiv = fileXmlRoot.descendantElements
                 .firstWhere(
diff --git a/app/test/task/testdata/goldens/documentation/oxygen/1.0.0/index.html b/app/test/task/testdata/goldens/documentation/oxygen/1.0.0/index.html
index ba379324a4..7d3e97dc31 100644
--- a/app/test/task/testdata/goldens/documentation/oxygen/1.0.0/index.html
+++ b/app/test/task/testdata/goldens/documentation/oxygen/1.0.0/index.html
@@ -85,7 +85,6 @@ <h5 class="hidden-xs">
             <a href="oxygen/">oxygen</a>
           </li>
         </ol>
-        <div id="dartdoc-sidebar-left-content"></div>
       </div>
       <div id="dartdoc-sidebar-right" class="sidebar sidebar-offcanvas-right"></div>
     </main>
diff --git a/app/test/task/testdata/goldens/documentation/oxygen/1.0.0/oxygen/index.html b/app/test/task/testdata/goldens/documentation/oxygen/1.0.0/oxygen/index.html
index 427a1dbf1b..67f4cf3c6c 100644
--- a/app/test/task/testdata/goldens/documentation/oxygen/1.0.0/oxygen/index.html
+++ b/app/test/task/testdata/goldens/documentation/oxygen/1.0.0/oxygen/index.html
@@ -121,7 +121,6 @@ <h5>
             <a href="../oxygen/">oxygen</a>
           </li>
         </ol>
-        <div id="dartdoc-sidebar-left-content"></div>
       </div>
       <div id="dartdoc-sidebar-right" class="sidebar sidebar-offcanvas-right">
         <h5>oxygen library</h5>
diff --git a/app/test/task/testdata/goldens/documentation/oxygen/2.0.0/index.html b/app/test/task/testdata/goldens/documentation/oxygen/2.0.0/index.html
index 3d6fca3f47..27d972d9b0 100644
--- a/app/test/task/testdata/goldens/documentation/oxygen/2.0.0/index.html
+++ b/app/test/task/testdata/goldens/documentation/oxygen/2.0.0/index.html
@@ -85,7 +85,6 @@ <h5 class="hidden-xs">
             <a href="oxygen/">oxygen</a>
           </li>
         </ol>
-        <div id="dartdoc-sidebar-left-content"></div>
       </div>
       <div id="dartdoc-sidebar-right" class="sidebar sidebar-offcanvas-right"></div>
     </main>
diff --git a/app/test/task/testdata/goldens/documentation/oxygen/2.0.0/oxygen/index.html b/app/test/task/testdata/goldens/documentation/oxygen/2.0.0/oxygen/index.html
index a77e162dd0..4cd6b82d22 100644
--- a/app/test/task/testdata/goldens/documentation/oxygen/2.0.0/oxygen/index.html
+++ b/app/test/task/testdata/goldens/documentation/oxygen/2.0.0/oxygen/index.html
@@ -121,7 +121,6 @@ <h5>
             <a href="../oxygen/">oxygen</a>
           </li>
         </ol>
-        <div id="dartdoc-sidebar-left-content"></div>
       </div>
       <div id="dartdoc-sidebar-right" class="sidebar sidebar-offcanvas-right">
         <h5>oxygen library</h5>
diff --git a/app/test/task/testdata/goldens/documentation/oxygen/latest/index.html b/app/test/task/testdata/goldens/documentation/oxygen/latest/index.html
index 3d0f07ad86..7b25905de7 100644
--- a/app/test/task/testdata/goldens/documentation/oxygen/latest/index.html
+++ b/app/test/task/testdata/goldens/documentation/oxygen/latest/index.html
@@ -83,7 +83,6 @@ <h5 class="hidden-xs">
             <a href="oxygen/">oxygen</a>
           </li>
         </ol>
-        <div id="dartdoc-sidebar-left-content"></div>
       </div>
       <div id="dartdoc-sidebar-right" class="sidebar sidebar-offcanvas-right"></div>
     </main>
diff --git a/app/test/task/testdata/goldens/documentation/oxygen/latest/oxygen/index.html b/app/test/task/testdata/goldens/documentation/oxygen/latest/oxygen/index.html
index 475f42794e..0189d37a64 100644
--- a/app/test/task/testdata/goldens/documentation/oxygen/latest/oxygen/index.html
+++ b/app/test/task/testdata/goldens/documentation/oxygen/latest/oxygen/index.html
@@ -119,7 +119,6 @@ <h5>
             <a href="../oxygen/">oxygen</a>
           </li>
         </ol>
-        <div id="dartdoc-sidebar-left-content"></div>
       </div>
       <div id="dartdoc-sidebar-right" class="sidebar sidebar-offcanvas-right">
         <h5>oxygen library</h5>