Skip to content

Commit 9b3a8da

Browse files
committed
app: qt 6 audio fixes
1 parent 68c35f3 commit 9b3a8da

File tree

2 files changed

+9
-14
lines changed

2 files changed

+9
-14
lines changed

app/viewer/mediapanel.cpp

+8-13
Original file line numberDiff line numberDiff line change
@@ -394,6 +394,8 @@ void MediaPanel::Play(bool e)
394394
auto output_dev = QAudioDevice(QMediaDevices::defaultAudioOutput());
395395
auto fmt = output_dev.preferredFormat();
396396

397+
ClearAudioSinks();
398+
397399
for (auto it=m_mediaInstances.cbegin(); it!=m_mediaInstances.cend(); it++) {
398400
auto m = *it;
399401

@@ -407,7 +409,6 @@ void MediaPanel::Play(bool e)
407409
auto out = new QAudioSink(output_dev, fmt, this);
408410
out->setVolume(m->GetVolume());
409411
out->start(m);
410-
connect(out, &QAudioSink::stateChanged, this, &MediaPanel::AudioStateChanged);
411412
m_audioSinks.push_back(out);
412413
has_audio = true;
413414
}
@@ -449,9 +450,7 @@ void MediaPanel::TimerUpdate()
449450
}
450451

451452
if (all_eof) {
452-
// Detach audio output so that it flushes itself
453-
m_audioSinks.clear();
454-
453+
ClearAudioSinks();
455454
Play(false);
456455
m_PlayheadSlider->setValue(m_PlayheadSlider->maximum());
457456
}
@@ -506,17 +505,13 @@ void MediaPanel::LabelContextMenuTriggered(const QPoint &pos)
506505
m.exec(static_cast<QWidget*>(sender())->mapToGlobal(pos));
507506
}
508507

509-
void MediaPanel::AudioStateChanged(QAudio::State newState)
508+
void MediaPanel::ClearAudioSinks()
510509
{
511-
if (newState == QAudio::IdleState) {
512-
auto out = static_cast<QAudioSink*>(sender());
510+
if (m_audioSinks.size() != 0) {
511+
for (auto s : m_audioSinks)
512+
delete s;
513513

514-
auto it = std::find(m_audioSinks.begin(), m_audioSinks.end(), out);
515-
if (it != m_audioSinks.end()) {
516-
m_audioSinks.erase(it);
517-
}
518-
519-
delete out;
514+
m_audioSinks.clear();
520515
}
521516
}
522517

app/viewer/mediapanel.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ private slots:
180180

181181
void LabelContextMenuTriggered(const QPoint &pos);
182182

183-
void AudioStateChanged(QAudio::State newState);
183+
void ClearAudioSinks();
184184

185185
};
186186

0 commit comments

Comments
 (0)