Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inverser la dépendance de la base url #14

Open
marc-bouvier opened this issue Apr 19, 2024 · 0 comments
Open

Inverser la dépendance de la base url #14

marc-bouvier opened this issue Apr 19, 2024 · 0 comments

Comments

@marc-bouvier
Copy link
Contributor

Certains composants s'appuient sur la variable import { base } from '$app/paths';.
Ce qui crée un couplage avec sveltekit.

L'url de base devrait être injectée sous forme de prop pour être gérée par les utilisateurs du composant, pas par le design-system.

https://github.com/iroco-co/iroco-ui/blob/55ee53c8bbe9c95c3074bb6b8a9bebb3a880a28c/src/lib/Navigation.svelte#L8C2-L8C36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant