Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review histogram ranges #23

Open
ingomueller-net opened this issue Apr 14, 2021 · 2 comments
Open

Review histogram ranges #23

ingomueller-net opened this issue Apr 14, 2021 · 2 comments
Assignees

Comments

@ingomueller-net
Copy link
Contributor

In offline communication:

[...] it seems like the histogram bounds should be adapted,
no? For example, the histogram for Q1 ranges from 0 to 2000 but the largest
value (in the first 1000 events) is in the [120,140) bin. Other histograms
plotting pt values range from 15 to 60. Should the ranges of queries 1, 4, 5, and
8 not be adjusted accordingly?

Yes, they should be. Actually I think the ranges for all of the benchmarks should
be reviewed.

@masonproffitt
Copy link
Member

Well, right now, there aren't any histogram parameters (such as ranges) at all in the benchmark tasks. These are only defined per implementation. But this should definitely be done as part of #12.

@ingomueller-net
Copy link
Contributor Author

OK, sure.

@masonproffitt masonproffitt self-assigned this Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants