Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Codegen][NFC] Remove the HAL dependency from the Codegen dialect. #19311

Merged
merged 3 commits into from
Nov 27, 2024
+10 −9
Merged

[Codegen][NFC] Remove the HAL dependency from the Codegen dialect. #19311

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b67cde
[Codegen][NFC] Remove the HAL dependency from the Codegen dialect.
hanhanW Nov 27, 2024
64752bb
IWYU
hanhanW Nov 27, 2024
f39e91b
IWYU..
hanhanW Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion compiler/src/iree/compiler/Codegen/Dialect/Codegen/IR/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ iree_compiler_cc_library(
":LoweringConfigInterfaceGen",
":UKernelOpsGen",
"//compiler/src/iree/compiler/Codegen/Interfaces:UKernelOpInterface",
"//compiler/src/iree/compiler/Dialect/HAL/IR",
"@llvm-project//llvm:Support",
"@llvm-project//mlir:ArithDialect",
"@llvm-project//mlir:ArithUtils",
Expand Down
1 change: 0 additions & 1 deletion compiler/src/iree/compiler/Codegen/Dialect/Codegen/IR/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ iree_cc_library(
MLIRTransformDialectTransforms
MLIRViewLikeInterface
iree::compiler::Codegen::Interfaces::UKernelOpInterface
iree::compiler::Dialect::HAL::IR
PUBLIC
)

Expand Down
4 changes: 2 additions & 2 deletions compiler/src/iree/compiler/Codegen/Dialect/Codegen/IR/IREECodegenAttrs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,8 +476,8 @@ void IREECodegenDialect::initializeCodegenAttrs() {
namespace mlir::iree_compiler {

//===----------------------------------------------------------------------===//
// Helpers for getting/setting iree_codegen.translation_info attribute on the
// `hal.executable.export`
// Helpers for getting/setting iree_codegen.translation_info attribute on a
// FunctionOpInterface op.
// ===----------------------------------------------------------------------===//

IREE::Codegen::TranslationInfoAttr
Expand Down
9 changes: 4 additions & 5 deletions compiler/src/iree/compiler/Codegen/Dialect/Codegen/IR/IREECodegenAttrs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
#define IREE_COMPILER_CODEGEN_DIALECT_LOWERINGCONFIG_H_

#include "iree/compiler/Codegen/Dialect/Codegen/IR/IREECodegenInterfaces.h"
#include "iree/compiler/Dialect/HAL/IR/HALOps.h"
#include "mlir/Dialect/SCF/IR/DeviceMappingInterface.h"
#include "mlir/IR/Builders.h"
#include "mlir/IR/BuiltinAttributes.h"
Expand Down Expand Up @@ -43,8 +42,8 @@ constexpr StringLiteral kTuningSpecAttrName =
constexpr StringLiteral kKernelConfigSpecName = "__kernel_config";

//===----------------------------------------------------------------------===//
// Helpers for getting/setting iree_codegen.translation_info attribute on the
// `hal.executable.export`
// Helpers for getting/setting iree_codegen.translation_info attribute on a
// FunctionOpInterface op.
//===----------------------------------------------------------------------===//

/// Returns the translation info for the `funcOp`. Returns `nullptr` on failure.
Expand All @@ -59,8 +58,8 @@ getWorkgroupSize(mlir::FunctionOpInterface funcOp);
std::optional<int64_t> getSubgroupSize(mlir::FunctionOpInterface funcOp);

/// Sets and overwites the translate executable info for the given entry point.
/// Returns failure if the given entry point is not exported via
/// hal.executable.export.
/// Returns success() at the end. It is convenient when a caller need to
/// propagate the state.
LogicalResult
setTranslationInfo(mlir::FunctionOpInterface entryPoint,
IREE::Codegen::TranslationInfoAttr translationInfo);
Expand Down
Loading