Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] Make detection of TimeoutError compatible with 3.10. #19308

Merged
merged 2 commits into from
Nov 26, 2024
Merged

[python] Make detection of TimeoutError compatible with 3.10. #19308

merged 2 commits into from
Nov 26, 2024

Commits on Nov 26, 2024

  1. [python] Make detection of TimeoutError compatible with 3.10. 

    * In python < 3.11, future methods throw concurrent.futures.TimeoutError.
* In python 3.11, concurrent.futures.TimeoutError is a subclass of TimeoutError and the former is deprecated.
* In python 3.10, TimeoutError exists so can have an except clause, but it is not thrown by futures.

Signed-off-by: Stella Laurenzo <[email protected]>
    @stellaraccident
    stellaraccident committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    a2cc252 View commit details
    Browse the repository at this point in the history

  2. Fix comment 

    Signed-off-by: Stella Laurenzo <[email protected]>
    @stellaraccident
    stellaraccident committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    6dbd211 View commit details
    Browse the repository at this point in the history