Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a llama 3.1 toy test with cross entropy test #50

Merged
merged 8 commits into from
Nov 27, 2024

Conversation

rsuderman
Copy link
Contributor

If we pick the maximum token each decode step we should get a somewhat consistent cross entropy loss. This uses a prebaked llama model. The irpa file should stay static but the mlir model should update as features are enabled.

If we pick the maximum token each decode step we should get a somewhat
consistent cross entropy loss. This uses a prebaked llama model. The
`irpa` file should stay static but the `mlir` model should update as
features are enabled.
Copy link
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The top level sharktank_models path SGTM. We can shuffle things around later as more tests are added too.

A few mostly structural and style comments.

sharktank_models/llama3.1/test_llama.py Show resolved Hide resolved
sharktank_models/llama3.1/test_llama.py Outdated Show resolved Hide resolved
sharktank_models/llama3.1/assets/toy_llama.irpa Outdated Show resolved Hide resolved
sharktank_models/llama3.1/test_llama.py Outdated Show resolved Hide resolved
sharktank_models/llama3.1/test_llama.py Outdated Show resolved Hide resolved
sharktank_models/llama3.1/test_llama.py Show resolved Hide resolved
sharktank_models/llama3.1/test_llama.py Outdated Show resolved Hide resolved
sharktank_models/llama3.1/test_llama.py Show resolved Hide resolved
sharktank_models/llama3.1/test_llama.py Show resolved Hide resolved
sharktank_models/llama3.1/test_llama.py Outdated Show resolved Hide resolved
Copy link
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks for the changes!

sharktank_models/llama3.1/README Outdated Show resolved Hide resolved
.github/workflows/test_sharktank_models.yml Show resolved Hide resolved
@rsuderman rsuderman merged commit a0c84d5 into iree-org:main Nov 27, 2024
2 checks passed
@rsuderman rsuderman deleted the llama3b_prefill branch November 27, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants