Skip to content

Commit 10bcb95

Browse files
authored
test(log): cleaunp TextDecoder use (denoland#5407)
tests(log): cleaunp `TextDecoder` use
1 parent a32c05f commit 10bcb95

File tree

2 files changed

+5
-17
lines changed

2 files changed

+5
-17
lines changed

log/file_handler_test.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,7 @@ Deno.test({
1212
class TestFileHandler extends FileHandler {
1313
override flush() {
1414
super.flush();
15-
const decoder = new TextDecoder("utf-8");
16-
const data = Deno.readFileSync(LOG_FILE);
17-
const text = decoder.decode(data);
15+
const text = Deno.readTextFileSync(LOG_FILE);
1816
assertEquals(text.slice(-1), "\n");
1917
}
2018

log/rotating_file_handler_test.ts

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -204,20 +204,10 @@ Deno.test({
204204
); // 'ERROR AAA\n' = 10 bytes
205205
fileHandler.destroy();
206206

207-
const decoder = new TextDecoder();
208-
assertEquals(decoder.decode(Deno.readFileSync(LOG_FILE)), "ERROR AAA\n");
209-
assertEquals(
210-
decoder.decode(Deno.readFileSync(LOG_FILE + ".1")),
211-
"original log file",
212-
);
213-
assertEquals(
214-
decoder.decode(Deno.readFileSync(LOG_FILE + ".2")),
215-
"original log.1 file",
216-
);
217-
assertEquals(
218-
decoder.decode(Deno.readFileSync(LOG_FILE + ".3")),
219-
"original log.2 file",
220-
);
207+
assertEquals(Deno.readTextFileSync(LOG_FILE), "ERROR AAA\n");
208+
assertEquals(Deno.readTextFileSync(LOG_FILE + ".1"), "original log file");
209+
assertEquals(Deno.readTextFileSync(LOG_FILE + ".2"), "original log.1 file");
210+
assertEquals(Deno.readTextFileSync(LOG_FILE + ".3"), "original log.2 file");
221211
assert(!existsSync(LOG_FILE + ".4"));
222212

223213
Deno.removeSync(LOG_FILE);

0 commit comments

Comments
 (0)