Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway: support for UnixFS 1.5 Last-Modified/If-Modified-Since with remote CAR backend #664

Open
8 tasks
lidel opened this issue Aug 27, 2024 · 0 comments
Open
8 tasks
Labels
dif/medium Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up topic/gateway Issues related to HTTP Gateway

Comments

@lidel
Copy link
Member

lidel commented Aug 27, 2024

#659 introduced support for returning optional UnixFS 1.5 mtime value as Last-Modified header, and returning 304 Not Modified if it is matching If-Modified-Since sent with a file request.

This

Remaining work here:

  • prerequisites
    • figure out what is missing in loadTerminalEntity from gateway/backend_car.go to be able to read mtime from the root dag-pb block of requested file, update any upstream libraries if necessary
  • car backend
    • return Last-Modified on deserialized GET responses
    • return Last-Modified on deserialized HEAD responses
    • 304 Not Modified on matching If-Modified-Since (UnixFS 1.5 file only)
  • add gateway-conformance test for unixfs 1.5 and release it as new major version
    • confirm conformance passes with all backends (remote car uses different implementation of Get and Head and ContentPathMetadata needs to be updated there as well -- this is why conformance tests need to be added after we have car backend implemented first)
@lidel lidel added P2 Medium: Good to have, but can wait until someone steps up dif/medium Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature topic/gateway Issues related to HTTP Gateway labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dif/medium Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up topic/gateway Issues related to HTTP Gateway
Projects
None yet
Development

No branches or pull requests

1 participant