support broadcast to unsubscribe topic #36
+335
−304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinxie
reviewed
Feb 28, 2023
dustinxie
reviewed
Feb 28, 2023
dustinxie
reviewed
Feb 28, 2023
10 tasks
dustinxie
reviewed
Mar 3, 2023
dustinxie
reviewed
Mar 3, 2023
dustinxie
reviewed
Mar 3, 2023
dustinxie
reviewed
Mar 8, 2023
dustinxie
reviewed
Mar 8, 2023
p2p.go
Outdated
| @@ -501,7 +502,7 @@ func (h *Host) AddBroadcastPubSub(ctx context.Context, topic string, callback Ha | |||
| if err != nil { | |||
| return err | |||
| } | |||
| h.pubs[topic] = top | |||
| h.pubs.Store(topic, top) | |||
| h.blacklists[topic] = blacklist | |||
| h.subs[topic] = sub | |||
There was a problem hiding this comment.
make L488 - 491 + 496 a func getOrAddPub(topic string)
dustinxie
reviewed
Mar 8, 2023
| } | ||
| } else { | ||
| pub = pubVal.(*pubsub.Topic) | ||
| } |
There was a problem hiding this comment.
pub, err := h.getOrAddPubsub(topic)
dustinxie
reviewed
Mar 8, 2023
p2p.go
Outdated
| @@ -731,6 +746,22 @@ func (h *Host) allowSource(src core.PeerID) (bool, error) { | |||
| return limiter.Allow(), nil | |||
| } | |||
|
|
|||
| func (h *Host) addPub(topic string) (*pubsub.Topic, error) { | |||
CoderZhi
reviewed
Mar 13, 2023
envestcc
changed the title
envestcc
changed the title
Liuhaai
reviewed
Dec 26, 2023
| @@ -16,7 +16,7 @@ jobs: | |||
| - name: Set up Go | |||
| uses: actions/setup-go@v2 | |||
| with: | |||
| go-version: 1.14 | |||
| go-version: 1.18.5 | |||
There was a problem hiding this comment.
upgrading golang in a separate pr
Liuhaai
reviewed
Dec 26, 2023
| return err | ||
| } | ||
| // publishing unsubscribed topic will fail when no connected peers, it should return error | ||
| _, subscribed := h.pubsubManager.getSub(topic) |
There was a problem hiding this comment.
how is the subscription of topics from connected peers detected?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary:
Broadcastsupport unsubscribed topicConnectedPeersByBroadcastTopic