removed custom viewmodel ability for now

Author: carlpoole

IonicPortals/src/main/kotlin/io/ionic/portals/PortalFragment.kt

@@ -52,41 +52,25 @@ open class PortalFragment : Fragment {
     private var initialContext: Any? = null
 
     private val viewModel: PortalViewModel by viewModels()
-    private var providedViewModel: PortalViewModel? = null
 
     constructor()
 
     constructor(portal: Portal?) {
         this.portal = portal
     }
 
-    constructor(portal: Portal?, viewModel: PortalViewModel) {
-        this.portal = portal
-        this.providedViewModel = viewModel
-    }
-
     constructor(portal: Portal?, onBridgeAvailable: ((bridge: Bridge) -> Unit)?) {
         this.portal = portal
         this.onBridgeAvailable = onBridgeAvailable
     }
 
-    constructor(portal: Portal?, viewModel: PortalViewModel, onBridgeAvailable: ((bridge: Bridge) -> Unit)?) : super() {
-        this.portal = portal
-        this.providedViewModel = viewModel
-        this.onBridgeAvailable = onBridgeAvailable
-    }
-
     /**
      * Extends the Android Fragment `onCreate` lifecycle event.
      */
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
         portal?.let { portal ->
-            if(providedViewModel != null) {
-                providedViewModel?.state?.value = portal
-            } else {
-                viewModel.state.value = portal
-            }
+            viewModel.state.value = portal
         }
     }
 
@@ -109,14 +93,8 @@ open class PortalFragment : Fragment {
      */
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)
-        if (providedViewModel != null) {
-            providedViewModel?.state?.value?.let {
-                portal = it
-            }
-        } else {
-            viewModel.state.value?.let {
-                portal = it
-            }
+        viewModel.state.value?.let {
+            portal = it
         }
         load(savedInstanceState)
     }

TestApp/src/main/AndroidManifest.xml

@@ -20,6 +20,7 @@
         <activity
             android:name=".ViewModelActivity"
             android:exported="true">
+
             <intent-filter>
                 <action android:name="android.intent.action.VIEW" />
                 <category android:name="android.intent.category.DEFAULT" />

TestApp/src/main/java/io/ionic/portals/testapp/ViewModelActivity.kt

@@ -21,8 +21,7 @@ class ViewModelActivity : AppCompatActivity() {
                 add(
                     R.id.fragmentContainerView,
                     PortalFragment(
-                        portal = PortalBuilder("testportal").create(),
-                        viewModel = viewModel
+                        portal = PortalBuilder("testportal").create()
                     ),
                     "test"
                 )