Skip to content

Commit e23db80

Browse files
Viktor Rosendahlrostedt
authored andcommitted
tracing/tools: Add the latency-collector to tools directory
This is a tool that is intended to work around the fact that the preemptoff, irqsoff, and preemptirqsoff tracers only work in overwrite mode. The idea is to act randomly in such a way that we do not systematically lose any latencies, so that if enough testing is done, all latencies will be captured. If the same burst of latencies is repeated, then sooner or later we will have captured all the latencies. It also works with the wakeup_dl, wakeup_rt, and wakeup tracers. However, in that case it is probably not useful to use the random sleep functionality. The reason why it may be desirable to catch all latencies with a long test campaign is that for some organizations, it's necessary to test the kernel in the field and not practical for developers to work iteratively with field testers. Because of cost and project schedules it is not possible to start a new test campaign every time a latency problem has been fixed. It uses inotify to detect changes to /sys/kernel/tracing/trace. When a latency is detected, it will either sleep or print immediately, depending on a function that act as an unfair coin toss. If immediate print is chosen, it means that we open /sys/kernel/tracing/trace and thereby cause a blackout period that will hide any subsequent latencies. If sleep is chosen, it means that we wait before opening /sys/kernel/tracing/trace, by default for 1000 ms, to see if there is another latency during this period. If there is, then we will lose the previous latency. The coin will be tossed again with a different probability, and we will either print the new latency, or possibly a subsequent one. The probability for the unfair coin toss is chosen so that there is equal probability to obtain any of the latencies in a burst. However, this assumes that we make an assumption of how many latencies there can be. By default the program assumes that there are no more than 2 latencies in a burst, the probability of immediate printout will be: 1/2 and 1 Thus, the probability of getting each of the two latencies will be 1/2. If we ever find that there is more than one latency in a series, meaning that we reach the probability of 1, then the table will be expanded to: 1/3, 1/2, and 1 Thus, we assume that there are no more than three latencies and each with a probability of 1/3 of being captured. If the probability of 1 is reached in the new table, that is we see more than two closely occurring latencies, then the table will again be extended, and so on. On my systems, it seems like this scheme works fairly well, as long as the latencies we trace are long enough, 300 us seems to be enough. This userspace program receive the inotify event at the end of a latency, and it has time until the end of the next latency to react, that is to open /sys/kernel/tracing/trace. Thus, if we trace latencies that are >300 us, then we have at least 300 us to react. The minimum latency will of course not be 300 us on all systems, it will depend on the hardware, kernel version, workload and configuration. Example usage: In one shell, give the following command: sudo latency-collector -rvv -t preemptirqsoff -s 2000 -a 3 This will trace latencies > 2000us with the preemptirqsoff tracer, using random sleep with maximum verbosity, with a probability table initialized to a size of 3. In another shell, generate a few bursts of latencies: root@host:~# modprobe preemptirq_delay_test delay=3000 test_mode=alternate burst_size=3 root@host:~# echo 1 > /sys/kernel/preemptirq_delay_test/trigger root@host:~# echo 1 > /sys/kernel/preemptirq_delay_test/trigger root@host:~# echo 1 > /sys/kernel/preemptirq_delay_test/trigger root@host:~# echo 1 > /sys/kernel/preemptirq_delay_test/trigger If all goes well, you should be getting stack traces that shows all the different latencies, i.e. you should see all the three functions preemptirqtest_0, preemptirqtest_1, preemptirqtest_2 in the stack traces. Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Viktor Rosendahl <[email protected]> Signed-off-by: Steven Rostedt (VMware) <[email protected]>
1 parent 99e22ce commit e23db80

File tree

5 files changed

+2161
-6
lines changed

5 files changed

+2161
-6
lines changed

tools/Makefile

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ help:
3131
@echo ' bootconfig - boot config tool'
3232
@echo ' spi - spi tools'
3333
@echo ' tmon - thermal monitoring and tuning tool'
34+
@echo ' tracing - misc tracing tools'
3435
@echo ' turbostat - Intel CPU idle stats and freq reporting tool'
3536
@echo ' usb - USB testing tools'
3637
@echo ' virtio - vhost test module'
@@ -64,7 +65,7 @@ acpi: FORCE
6465
cpupower: FORCE
6566
$(call descend,power/$@)
6667

67-
cgroup firewire hv guest bootconfig spi usb virtio vm bpf iio gpio objtool leds wmi pci firmware debugging: FORCE
68+
cgroup firewire hv guest bootconfig spi usb virtio vm bpf iio gpio objtool leds wmi pci firmware debugging tracing: FORCE
6869
$(call descend,$@)
6970

7071
bpf/%: FORCE
@@ -103,15 +104,15 @@ all: acpi cgroup cpupower gpio hv firewire liblockdep \
103104
perf selftests bootconfig spi turbostat usb \
104105
virtio vm bpf x86_energy_perf_policy \
105106
tmon freefall iio objtool kvm_stat wmi \
106-
pci debugging
107+
pci debugging tracing
107108

108109
acpi_install:
109110
$(call descend,power/$(@:_install=),install)
110111

111112
cpupower_install:
112113
$(call descend,power/$(@:_install=),install)
113114

114-
cgroup_install firewire_install gpio_install hv_install iio_install perf_install bootconfig_install spi_install usb_install virtio_install vm_install bpf_install objtool_install wmi_install pci_install debugging_install:
115+
cgroup_install firewire_install gpio_install hv_install iio_install perf_install bootconfig_install spi_install usb_install virtio_install vm_install bpf_install objtool_install wmi_install pci_install debugging_install tracing_install:
115116
$(call descend,$(@:_install=),install)
116117

117118
liblockdep_install:
@@ -137,15 +138,16 @@ install: acpi_install cgroup_install cpupower_install gpio_install \
137138
perf_install selftests_install turbostat_install usb_install \
138139
virtio_install vm_install bpf_install x86_energy_perf_policy_install \
139140
tmon_install freefall_install objtool_install kvm_stat_install \
140-
wmi_install pci_install debugging_install intel-speed-select_install
141+
wmi_install pci_install debugging_install intel-speed-select_install \
142+
tracing_install
141143

142144
acpi_clean:
143145
$(call descend,power/acpi,clean)
144146

145147
cpupower_clean:
146148
$(call descend,power/cpupower,clean)
147149

148-
cgroup_clean hv_clean firewire_clean bootconfig_clean spi_clean usb_clean virtio_clean vm_clean wmi_clean bpf_clean iio_clean gpio_clean objtool_clean leds_clean pci_clean firmware_clean debugging_clean:
150+
cgroup_clean hv_clean firewire_clean bootconfig_clean spi_clean usb_clean virtio_clean vm_clean wmi_clean bpf_clean iio_clean gpio_clean objtool_clean leds_clean pci_clean firmware_clean debugging_clean tracing_clean:
149151
$(call descend,$(@:_clean=),clean)
150152

151153
liblockdep_clean:
@@ -184,6 +186,6 @@ clean: acpi_clean cgroup_clean cpupower_clean hv_clean firewire_clean \
184186
vm_clean bpf_clean iio_clean x86_energy_perf_policy_clean tmon_clean \
185187
freefall_clean build_clean libbpf_clean libsubcmd_clean liblockdep_clean \
186188
gpio_clean objtool_clean leds_clean wmi_clean pci_clean firmware_clean debugging_clean \
187-
intel-speed-select_clean
189+
intel-speed-select_clean tracing_clean
188190

189191
.PHONY: FORCE

tools/tracing/Makefile

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
# SPDX-License-Identifier: GPL-2.0
2+
include ../scripts/Makefile.include
3+
4+
all: latency
5+
6+
clean: latency_clean
7+
8+
install: latency_install
9+
10+
latency:
11+
$(call descend,latency)
12+
13+
latency_install:
14+
$(call descend,latency,install)
15+
16+
latency_clean:
17+
$(call descend,latency,clean)
18+
19+
.PHONY: all install clean latency latency_install latency_clean

tools/tracing/latency/.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
# SPDX-License-Identifier: GPL-2.0
2+
latency-collector

tools/tracing/latency/Makefile

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
# SPDX-License-Identifier: GPL-2.0
2+
# Makefile for vm tools
3+
#
4+
VAR_CFLAGS := $(shell pkg-config --cflags libtracefs 2>/dev/null)
5+
VAR_LDLIBS := $(shell pkg-config --libs libtracefs 2>/dev/null)
6+
7+
TARGETS = latency-collector
8+
CFLAGS = -Wall -Wextra -g -O2 $(VAR_CFLAGS)
9+
LDFLAGS = -lpthread $(VAR_LDLIBS)
10+
11+
all: $(TARGETS)
12+
13+
%: %.c
14+
$(CC) $(CFLAGS) -o $@ $< $(LDFLAGS)
15+
16+
clean:
17+
$(RM) latency-collector
18+
19+
prefix ?= /usr/local
20+
sbindir ?= ${prefix}/sbin
21+
22+
install: all
23+
install -d $(DESTDIR)$(sbindir)
24+
install -m 755 -p $(TARGETS) $(DESTDIR)$(sbindir)

0 commit comments

Comments
 (0)