remove flask upper pin #411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* the test raises a permission denied error. this is then handled by the UOW by rolling back the session. this rollback also removes the test data from the session. the testdata is then not existing anymore for the following up test cases. moving those three in different test functions solves the problem. * another solution would be to find out to only roll back the last savepoint but at the moment of the rollback no savepoint is open so the whole session will be rolledback.
* the problem was that with sqlalchemy some strange rollback happened since the exception was raised. * with this change the re raise is not necessary anymore
* create a forward change to be compatible with sqlalchemy >= 2.0 and flask-sqlalchemy >= 3.0 * the biggest change is to go away from commit driven approach. in sqlalchemy it is more done with transactions. * a explicit call of a commit triggers a COMMIT event and writes to the database and therefore it couldn't be rolledback anymore
* this change should not be necessary, investigate more to find the real problem
* more thought should be given to this
utnapischtim
force-pushed
the
remove-flask-upper-pin
branch
from
3e70d76 to
2b5473b
Compare
|
NOTE: 01dd4e3 should be discussed! |
|
superseded by #432 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE:
the last two commits should be discussed