We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To determine "previewability" 2 approaches are taken relying on 2 different formats for file extensions
.txt
.zip
.png
txt
zip
png
has_previewable_files calls is_previewable(ext) calls current_previewer.previewable_extensions loads previewable_extensions from each plugin
This checks extensions in this format txt, md, zip...
md
preview calls plugin.can_preview calls file is a PreviewFile instance file.has_extensions( *[f".{ext}" for ext in previewable_extensions] )
checks extensions in this format .txt, .md, .zip...
.md
This minute difference can easily breakdown the preview and requires more maintenance.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
To determine "previewability" 2 approaches are taken relying on 2 different formats for file extensions
.txt
,.zip
,.png
...txt
,zip
,png
, ...Before showing previews
This checks extensions in this format
txt
,md
,zip
...When actually previewing
checks extensions in this format
.txt
,.md
,.zip
...This minute difference can easily breakdown the preview and requires more maintenance.
The text was updated successfully, but these errors were encountered: