Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: remove GITHUB_WEBHOOK_RECEIVER_ID #131

Open
slint opened this issue Aug 8, 2023 · 0 comments
Open

config: remove GITHUB_WEBHOOK_RECEIVER_ID #131

slint opened this issue Aug 8, 2023 · 0 comments

Comments

@slint
Copy link
Member

slint commented Aug 8, 2023

This config var seems only to be used for selecting the OAuth remote application config, so naming-wise it's wrong, and besides this, I wouldn't expect actually that we would ever use a remote different than the github one (for a module called invenio-github).

IMHO we can remove the variable and hardcode the github string it where it used to be. If the module ends up becoming more generic (e.g. to support GitLab), we would anyways require a pretty heavy refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant