You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This config var seems only to be used for selecting the OAuth remote application config, so naming-wise it's wrong, and besides this, I wouldn't expect actually that we would ever use a remote different than the github one (for a module called invenio-github).
IMHO we can remove the variable and hardcode the github string it where it used to be. If the module ends up becoming more generic (e.g. to support GitLab), we would anyways require a pretty heavy refactor.
The text was updated successfully, but these errors were encountered:
This config var seems only to be used for selecting the OAuth remote application config, so naming-wise it's wrong, and besides this, I wouldn't expect actually that we would ever use a remote different than the
github
one (for a module calledinvenio-github
).IMHO we can remove the variable and hardcode the
github
string it where it used to be. If the module ends up becoming more generic (e.g. to support GitLab), we would anyways require a pretty heavy refactor.The text was updated successfully, but these errors were encountered: