Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle undefined record attributes in templates to avoid rendering errors #2932

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix: Handle undefined record attributes in templates to avoid rendering errors #2932

wants to merge 6 commits into from

Conversation

Samk13
Copy link
Member

@Samk13 Samk13 commented Dec 5, 2024

❤️ Thank you for your contribution!

Description

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@Samk13
fix: improve handling of additional descriptions in detail template
9c97131 
* Handle missing 'type' in description rendering
* Add the missing description type when the type is not specified.
* closes inveniosoftware#2931
@Samk13 Samk13 force-pushed the fix-template-description-check branch from 3c86a5d to b723bc6 Compare December 5, 2024 01:59
@Samk13 Samk13 changed the title fix: improve handling of additional descriptions in detail template fix: Handle undefined record attributes in templates to avoid rendering errors Dec 5, 2024
@Samk13 Samk13 requested a review from tmorrell December 5, 2024 11:34
tmorrell
tmorrell approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@tmorrell tmorrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Samk13 this is amazing! It's like the fastest fix ever.

I've tested it on our instance and it solves the issue.

invenio_app_rdm/records_ui/templates/semantic-ui/invenio_app_rdm/records/macros/detail.html Outdated Show resolved Hide resolved
invenio_app_rdm/records_ui/templates/semantic-ui/invenio_app_rdm/records/macros/detail.html Outdated Show resolved Hide resolved
@Samk13 Samk13 force-pushed the fix-template-description-check branch from b723bc6 to 4cc21a0 Compare December 5, 2024 18:50
@Samk13
fix: improve handling for other fields
95c5d20 
* fix show_dates
* fix _identifiers_for_group
* fix show_related_identifiers by filtering with selectattr: https://jinja.palletsprojects.com/en/stable/templates/#jinja-filters.selectattr
@Samk13 Samk13 force-pushed the fix-template-description-check branch from 4cc21a0 to 95c5d20 Compare December 6, 2024 11:25
Samk13
Samk13 commented Dec 6, 2024
View reviewed changes
Copy link
Member Author

@Samk13 Samk13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added separate commits to safely access values. Some of these checks might be unnecessary. If you think it's overkill in certain macros, let me know and I’ll revert them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmorrell tmorrell tmorrell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incomplete records break community requests
2 participants
@Samk13 @tmorrell