Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete records break community requests #2931

Open
tmorrell opened this issue Dec 4, 2024 · 0 comments · May be fixed by #2932
Open

Incomplete records break community requests #2931

tmorrell opened this issue Dec 4, 2024 · 0 comments · May be fixed by #2932
Labels
bug Something isn't working

Comments

@tmorrell
Copy link
Contributor

tmorrell commented Dec 4, 2024

Package version (if known): v12

Describe the bug

If a curator is editing a record that has been submitted a community and saves a draft with validation errors, the request view will break.

Steps to Reproduce

  1. Create a record and submit it to a community
  2. A curator in the community edits the draft by adding an "Additional Description" and not filling out the "Type" field.
  3. Curator saves the draft, and a validation error appears which they ignore
  4. The request page https://inveniordm.web.cern.ch/communities/testing/requests/4d1e6f8a-171f-4844-b42c-ff5c5e2f83f6 has a 502 error

Expected behavior

Incomplete drafts shouldn't break the request page.

Additional context

I'm fairly certain this is because the request page record tab is trying to render the record preview on page load. Could the render happen when the tab is clicked? Or somehow catch the error and display an error message instead?

@tmorrell tmorrell added the bug Something isn't working label Dec 4, 2024
Samk13 added a commit to Samk13/invenio-app-rdm that referenced this issue Dec 5, 2024
* Handle missing 'type' in description rendering
* Add the missing description type when the type is not specified.
* closes inveniosoftware#2931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant