Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: uwsgi.ini extra config #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feature: uwsgi.ini extra config #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions charts/invenio/templates/uwsgi-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,3 +55,7 @@ data:
die-on-term = true
# hook-master-start = unix_signal:2 gracefully_kill_them_all
# hook-master-start = unix_signal:15 gracefully_kill_them_all
{{- range $key, $val := .Values.invenio.uwsgi_extra_config }}
{{ $key }} = {{ $val }}
{{- end -}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we drop the trailing -, just in case we want to add something more after this line in the future…

Suggested change
{{- end -}}
{{- end }}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be a trailing newline added here.

1 change: 1 addition & 0 deletions charts/invenio/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ invenio:
consumer_secret: ""
extra_config: {}
extra_env_from_secret: {}
uwsgi_extra_config: {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically, Helm values use camelCase and not snake_case. I suggest we change that.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have followed chart's convention
camelCase is better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This chart is inconsistent with what case it uses. But do as you wish. 🙃


haproxy:
enabled: true
Expand Down