feature: uwsgi.ini extra config #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plesoun-stein
force-pushed
the
extra-config-uwsgi
branch
from
cb08401 to
67e0e60
Compare
lindhe
reviewed
Mar 26, 2024
| @@ -37,6 +37,7 @@ invenio: | |||
| consumer_secret: "" | |||
| extra_config: {} | |||
| extra_env_from_secret: {} | |||
| uwsgi_extra_config: {} | |||
There was a problem hiding this comment.
Typically, Helm values use camelCase and not snake_case. I suggest we change that.
There was a problem hiding this comment.
I have followed chart's convention
camelCase is better.
There was a problem hiding this comment.
This chart is inconsistent with what case it uses. But do as you wish. 🙃
lindhe
reviewed
Mar 26, 2024
| {{- range $key, $val := .Values.invenio.uwsgi_extra_config }} | ||
| {{ $key }} = {{ $val }} | ||
| {{- end -}} | ||
|
|
There was a problem hiding this comment.
Seems to be a trailing newline added here.
lindhe
reviewed
Mar 26, 2024
| @@ -55,3 +55,7 @@ data: | |||
| die-on-term = true | |||
| # hook-master-start = unix_signal:2 gracefully_kill_them_all | |||
| # hook-master-start = unix_signal:15 gracefully_kill_them_all | |||
| {{- range $key, $val := .Values.invenio.uwsgi_extra_config }} | |||
| {{ $key }} = {{ $val }} | |||
| {{- end -}} | |||
There was a problem hiding this comment.
Maybe we drop the trailing -, just in case we want to add something more after this line in the future…
Suggested change
| {{- end -}} | |
| {{- end }} |
|
Apart from the minor things I've commented on, I think this looks good! 👍 Makes sense to insert values this way, I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
config map for uwsgi.ini is static file.
it may be helpfull to append extra config (yes, we need it)
details in issue #97
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Third-party code
If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: