New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable custom vocabularies via ConfigMaps #137

Merged

egabancho merged 1 commit into inveniosoftware:master from egabancho:custom-vocabularies

Dec 16, 2024

Member

egabancho commented Dec 3, 2024

Adds the option to customize vocabularies (closes Allow passing vocabulary files to the pods #135)
Adds proper labels everywhere

Contributor

lindhe commented Dec 4, 2024

Can vocabularies really fit in a ConfigMap? I was under the impression that they are often pretty big.

lindhe reviewed

View reviewed changes

charts/invenio/templates/logstash/filebeat-configmap.yaml Outdated Show resolved Hide resolved

egabancho force-pushed the custom-vocabularies branch 2 times, most recently from 73d1a37 to 006a018 Compare

December 5, 2024 21:39

lindhe reviewed

View reviewed changes

charts/invenio/templates/install-init-job.yaml Outdated Show resolved Hide resolved

lindhe reviewed

View reviewed changes

charts/invenio/templates/install-init-job.yaml Outdated Show resolved Hide resolved

lindhe reviewed

View reviewed changes

charts/invenio/templates/vocabularies-configmap.yaml Outdated Show resolved Hide resolved

lindhe reviewed

View reviewed changes

charts/invenio/templates/web-deployment.yaml Outdated Show resolved Hide resolved

lindhe reviewed

View reviewed changes

charts/invenio/templates/worker-beat-deployment.yaml Outdated Show resolved Hide resolved

lindhe reviewed

View reviewed changes

charts/invenio/templates/worker-deployment.yaml Outdated Show resolved Hide resolved

egabancho force-pushed the custom-vocabularies branch from 006a018 to 9362600 Compare

December 10, 2024 11:15

egabancho requested a review from lindhe

December 11, 2024 12:46

lindhe requested changes

View reviewed changes

Contributor

lindhe left a comment

Sorry for being so slow to review. I hate being a blocker.

Just have some minor comments here, mostly style changes. As soon as they are fixed (or answered) I approve this PR. 👍

charts/invenio/templates/vocabularies-configmap.yaml Outdated Show resolved Hide resolved

charts/invenio/templates/web-deployment.yaml Outdated Show resolved Hide resolved

charts/invenio/templates/worker-beat-deployment.yaml Outdated Show resolved Hide resolved

charts/invenio/templates/worker-deployment.yaml Outdated Show resolved Hide resolved

charts/invenio/templates/install-init-job.yaml Outdated Show resolved Hide resolved

charts/invenio/templates/install-init-job.yaml Show resolved Hide resolved

egabancho force-pushed the custom-vocabularies branch from 9362600 to 13e831c Compare

December 16, 2024 09:15

lindhe reviewed

View reviewed changes

charts/invenio/templates/vocabularies-configmap.yaml Outdated Show resolved Hide resolved

egabancho force-pushed the custom-vocabularies branch from 13e831c to 87cc83a Compare

December 16, 2024 12:33

lindhe approved these changes

View reviewed changes

lindhe changed the title ~~Custom vocabularies~~ Enable custom vocabularies via ConfigMaps


          invenio: add vocabularies

e072dcd

* Adds the option to customize vocabularies (closes inveniosoftware#135)

egabancho force-pushed the custom-vocabularies branch from 87cc83a to e072dcd Compare

December 16, 2024 13:45

egabancho merged commit e072dcd into inveniosoftware:master

egabancho deleted the custom-vocabularies branch

December 16, 2024 13:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet