-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing vocabulary files to the pods #135
Comments
* Adds the option to customize vocabularies (closes inveniosoftware#135)
I think loading vocabs via ConfigMaps may make sense, but I believe they are sometimes too big to fit in a ConfigMap. Do you know if Invenio has any kind of dynamic loading of resources that we could use, for example loading vocabs from S3 after container startup? |
They can be large, but they don't have to. These are the "default" ones to give you an idea https://github.com/inveniosoftware/invenio-rdm-records/tree/master/invenio_rdm_records/fixtures/data/vocabularies Honestly, it was the only way I could think of to load them into the pods. What I mean by that is that I am open to suggestions 😂
This is actually a good idea. Still, we will have to allow configuring the |
There is indeed a 1Mb limit on the config map size, https://kubernetes.io/docs/concepts/configuration/configmap/#motivation and https://stackoverflow.com/questions/53012798/kubernetes-configmap-size-limitation. Still, I believe this is a far simpler solution for smaller vocabularies (most of the cases). It is also doable to fetch larger data from a service, e.g., ORCID authors, or even from a file stored on S3. They shouldn't be mutually exclusive. |
Yes, I think this is viable for small vocabularies. I know ours at KTH are many GB in size, but that's maybe not the case for everyone. If we have this method in place, maybe that's helpful sometimes. And I know @Samk13 mentioned to me that there's work (or plans, at least) to implement some dynamic loading of vocabularies from outside sources directly in the application. That's probably the way to go for large vocabularies. |
You can check the progress here |
* Adds the option to customize vocabularies (closes inveniosoftware#135)
* Adds the option to customize vocabularies (closes inveniosoftware#135)
* Adds the option to customize vocabularies (closes inveniosoftware#135)
We have several instances that share the same docker image. It'd be nice to configure the vocabularies each one loads using the helm chart.
Maybe something like this:
The text was updated successfully, but these errors were encountered: