Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popping from stash (with merge conflict) causes issues #531

Open
isc-etamarch opened this issue Oct 8, 2024 · 3 comments · May be fixed by #653
Open

Popping from stash (with merge conflict) causes issues #531

isc-etamarch opened this issue Oct 8, 2024 · 3 comments · May be fixed by #653
Assignees
Labels
bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers) usability

Comments

@isc-etamarch
Copy link
Collaborator

Based on customer feedback

If popping changes from stash results in a merge conflict, the GitUI errors out, and the production is left in a broken state (in merge conflict state). There is no way to fix this through the UI, only manually fixing the merge conflict in the code.

We need to allow for a way to resolve the merge conflict without going directly into the code.

@isc-tleavitt What are your thoughts?

@isc-etamarch isc-etamarch added bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers) usability labels Oct 8, 2024
@isc-tleavitt
Copy link
Collaborator

isc-tleavitt commented Oct 8, 2024

I think the right option would be:
Attempt production configuration auto-resolve
If that fails, cancel the stash pop/apply (ideally preserving the stash?)

This is also a pointer toward recommending basic mode / per-developer namespaces to the customer, if not production decomposition when available, either of which would have provided a route less likely to encounter this issue.

@isc-etamarch
Copy link
Collaborator Author

This also causes the workspace view to error out. Trying to commit this change does not work, though discarding this file does not actually discard the file
image

@isc-tleavitt
Copy link
Collaborator

isc-tleavitt commented Oct 8, 2024

The other resolution option is to use the Web Application view of the repository, which gives you isfs access to the raw files. But we can't have that as the only/default option, and there needs to be a path to sanity through the UI.

@isc-tleavitt isc-tleavitt added this to the Q3/Q4 2024 Targets milestone Oct 8, 2024
@isc-tleavitt isc-tleavitt self-assigned this Oct 24, 2024
@isc-tleavitt isc-tleavitt removed their assignment Nov 8, 2024
@isc-etamarch isc-etamarch self-assigned this Nov 20, 2024
@isc-etamarch isc-etamarch linked a pull request Nov 21, 2024 that will close this issue
@isc-etamarch isc-etamarch linked a pull request Nov 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers) usability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants