Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter versions by prerelease and snapshot in request query str #112

Conversation

isc-shuliu
Copy link
Collaborator

@isc-shuliu isc-shuliu commented Aug 29, 2024

With this PR, we make use of 2 query params includePrerelease and includeSnapshots when searching for compatible versions of a package.

Corresponding client-side changes are made in the IPM repo (for release with 0.9.0)

Note: pursuant to the discussion here, we consider snapshot as a version with a prerelease tag of the string literal "snapshot". A version with any other non-empty prerelease tag is called a prerelease.

Fixes #91

@isc-tleavitt
Copy link
Contributor

@evshvarov is there another good reviewer for this?

@nsolov nsolov changed the base branch from master to stage September 3, 2024 08:17
@nsolov nsolov changed the base branch from stage to master September 3, 2024 08:49
@nsolov nsolov changed the base branch from master to stage September 3, 2024 08:50
@nsolov nsolov merged commit 5617543 into intersystems-community:stage Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Respect "use for snapshots" and "use for prereleases"
3 participants