zprint COS command does not work

[yaronmunz]

I have installed WebTerminal on IRIS 2019.1.0 and it is working great.
However, a ZP (zprint) COS command does not work.
when issuing for example:
zl test zp
I get the USER> prompt without anything
(if issuing the same on IRIS terminal, all work fine... i.e the routine has a source).

I have seen that the ZP (zprint) command is missing on the StaticContent class.
I tried to add it there, and then autocomplete of ZP (to zprint) works, but still not output is sent back to the client.

[nikitaeverywhere]

Hello @yaronmunz! Thank you for reporting this issue.

The thing is, we have a group of issues labeled Core Enhancement (blocker), which doesn't allow to run something exactly because of how WebTerminal works under the hood (on top of ObjectScript xecute + I/O redirection). Some system routines have their own rules for input/output (they switch output devices or expect some core terminal/system variables to be set by underlying I/O system), hence new problems appear.

I assume this wouldn't be the case if I implemented, for example, WebTerminal over telnet (because telnet wraps all internal execution magic and works exactly like a terminal), but it seems that this approach also has its own problems. Looks like telnet has its own disadvantages (is it Windows-only?).

So, currently, I am looking for an approach to change WebTerminal's core, which I belive will fix all similar issues, including yours.

[yaronmunz]

Hello, Thank you for your email. I have actually looked into the code. This is a nice implementation of WebSockets. I think that if you going to use a telnet (stream) object to handle all communication, it might be slower (in response) than the current response time with websocket. However, I think that some of the issues that were reported (I looked at some of them in github) might be solved with minimal coding of those special cases. (probably the same way you implement the sql feature). The command ZP (zprint) should not be an issue to use for example: Set routine = ##class(%Routine).%New("test.int") while 'routine.AtEnd { w !,routine.ReadLine() } Yaron Munz IRIS / Ensemble architect MSC MEDITERRANEAN SHIPPING COMPANY SA 16, Avenue Eugène Pittard , 1206 Geneva, Switzerland M: +41 78 721 6666 W: www.msc.com<http://www.msc.com/> From: Nikita Savchenko <[email protected]> Sent: Friday 28 June 2019 15:11 To: intersystems-community/webterminal <[email protected]> Cc: Yaron Munz (MSC Geneva) <[email protected]>; Mention <[email protected]> Subject: Re: [intersystems-community/webterminal] zprint COS command does not work (#125) Hello @yaronmunz<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fyaronmunz&data=02%7C01%7Cyaron.munz%40msc.com%7C3c27b6714b8c4ff472ad08d6fbca2207%7C088e9b00ffd0458ebfa1acf4c596d3cb%7C1%7C0%7C636973242908433881&sdata=8VlIftxCLOzMehRwqnBLEt2E8nInY3U9EpnJaLtxiwU%3D&reserved=0>! Thank you for reporting this issue. The thing is, we have a group of issues<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fintersystems-community%2Fwebterminal%2Fissues%3Fq%3Dis%253Aissue%2Bis%253Aopen%2Blabel%253A%2522Core%2BEnhancement%2B%2528blocker%2529%2522&data=02%7C01%7Cyaron.munz%40msc.com%7C3c27b6714b8c4ff472ad08d6fbca2207%7C088e9b00ffd0458ebfa1acf4c596d3cb%7C1%7C0%7C636973242908443889&sdata=I6z1UynCcsOAmApYIugOwnCFrHUdGk5nrAH%2BvTefxQA%3D&reserved=0> labeled Core Enhancement (blocker), which doesn't allow to run something exactly because of how WebTerminal works under the hood (on top of ObjectScript xecute + I/O redirection). Some system routines have their own rules for input/output (they switch output devices or expect some core terminal/system variables to be set by underlying I/O system), hence new problems appear. I assume this wouldn't be the case if I implemented, for example, WebTerminal over telnet<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fintersystems-community%2Fwebterminal%2Fissues%2F103&data=02%7C01%7Cyaron.munz%40msc.com%7C3c27b6714b8c4ff472ad08d6fbca2207%7C088e9b00ffd0458ebfa1acf4c596d3cb%7C1%7C0%7C636973242908443889&sdata=C6ZqDZU0IH79Jm2zxoW67UBQexg5pWR%2FPdVI8r412x0%3D&reserved=0> (because telnet wraps all internal execution magic and works exactly like a terminal), but it seems that this approach also has its own problems. Looks like telnet has its own disadvantages (is it Windows-only?). So, currently, I am looking for an approach to change WebTerminal's core, which I belive will fix all similar issues, including yours. - You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fintersystems-community%2Fwebterminal%2Fissues%2F125%3Femail_source%3Dnotifications%26email_token%3DAMO4CLKBZHHGPJIJSA4JVQLP4YEX7A5CNFSM4H32ZLQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY2A72Y%23issuecomment-506728427&data=02%7C01%7Cyaron.munz%40msc.com%7C3c27b6714b8c4ff472ad08d6fbca2207%7C088e9b00ffd0458ebfa1acf4c596d3cb%7C1%7C0%7C636973242908453902&sdata=aZNPUsfT6vsiZYoz%2FjfrnkWEdNSiC4nGy7ll%2B0lHc5g%3D&reserved=0>, or mute the thread<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMO4CLJRMP5K475OY7IZX2TP4YEX7ANCNFSM4H32ZLQA&data=02%7C01%7Cyaron.munz%40msc.com%7C3c27b6714b8c4ff472ad08d6fbca2207%7C088e9b00ffd0458ebfa1acf4c596d3cb%7C1%7C0%7C636973242908463910&sdata=W64s34ThGWaNOzzldcYcXHbLKBFxRQG3gC%2FmozwpY58%3D&reserved=0>. Sensitivity: Internal This message and any associated files (together the "Contents") are intended solely for the addressee(s). The Contents are confidential and may contain private information or information that is subject to copyright or is a trade secret or which is privileged. Views or opinions expressed herein do not necessarily represent views or opinions of MSC Mediterranean Shipping Company, its agents or their affiliated companies and may only be the view or opinion of the author. If you are not the intended recipient of this email, you must not use, print, copy, store, forward, or disclose it or act in reliance of the Contents. Please destroy all copies of the message and any associated files and notify the sender immediately that you have received it in error. Thank you for your cooperation.------MSC LEGAL DISCLAIMER

[nikitaeverywhere]

However, I think that some of the issues that were reported (I looked at some of them in github) might be solved with minimal coding of those special cases. (probably the same way you implement the sql feature).

Do you mean just hard-coding some cases like "if command = this then execute this custom code"? If so, this is a very dangerous way to fix things... At least, it hides an original behavior from the user, which may mislead them if the command has some options not covered by this "dirty fix".

[yaronmunz]

Hello Nikita. Yes, I agree that hard coding is "dangerous" and not the proper way to keep everything seamless. However, the "zl routine zp" command is a very special case that is always done without anything else at that line.. so, I have hard coded that : [cid:[email protected]] Yaron Munz IRIS / Ensemble architect MSC MEDITERRANEAN SHIPPING COMPANY SA 16, Avenue Eugène Pittard , 1206 Geneva, Switzerland M: +41 78 721 6666 W: www.msc.com<http://www.msc.com/> From: Nikita Savchenko <[email protected]> Sent: Friday 28 June 2019 19:51 To: intersystems-community/webterminal <[email protected]> Cc: Yaron Munz (MSC Geneva) <[email protected]>; Mention <[email protected]> Subject: Re: [intersystems-community/webterminal] zprint COS command does not work (#125) However, I think that some of the issues that were reported (I looked at some of them in github) might be solved with minimal coding of those special cases. (probably the same way you implement the sql feature). Do you mean just hard-coding some cases like "if command = this then execute this custom code"? If so, this is a very dangerous way to fix things... At least, it hides an original behavior from the user, which may mislead them if the command has some options not covered by this "dirty fix". - You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fintersystems-community%2Fwebterminal%2Fissues%2F125%3Femail_source%3Dnotifications%26email_token%3DAMO4CLJFZKRBCNFPVHUOE3TP4ZFRXA5CNFSM4H32ZLQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY2X57Y%23issuecomment-506822399&data=02%7C01%7Cyaron.munz%40msc.com%7Ce61913ec72504a1e0ecb08d6fbf13cd6%7C088e9b00ffd0458ebfa1acf4c596d3cb%7C1%7C0%7C636973410862790476&sdata=RyPfH945W%2BF6n8RPstvn3UXN96284%2FD0wd65R9GBfwA%3D&reserved=0>, or mute the thread<https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMO4CLNBR7DY5DOOPEI5RZTP4ZFRXANCNFSM4H32ZLQA&data=02%7C01%7Cyaron.munz%40msc.com%7Ce61913ec72504a1e0ecb08d6fbf13cd6%7C088e9b00ffd0458ebfa1acf4c596d3cb%7C1%7C0%7C636973410862790476&sdata=SUvrm4E1ETGoL4sSS9rEUdN%2B1Fnd3OyoSsTGkCcpQPQ%3D&reserved=0>. Sensitivity: Internal This message and any associated files (together the "Contents") are intended solely for the addressee(s). The Contents are confidential and may contain private information or information that is subject to copyright or is a trade secret or which is privileged. Views or opinions expressed herein do not necessarily represent views or opinions of MSC Mediterranean Shipping Company, its agents or their affiliated companies and may only be the view or opinion of the author. If you are not the intended recipient of this email, you must not use, print, copy, store, forward, or disclose it or act in reliance of the Contents. Please destroy all copies of the message and any associated files and notify the sender immediately that you have received it in error. Thank you for your cooperation.------MSC LEGAL DISCLAIMER

[nikitaeverywhere]

I understand this case. However, I would keep hard-coding away from the "official" releases. Just another possible case from numerous cases... If the project goes wild (for example, a maintainer changes) then people will start to hard-code everything by example, and this will turn into a total mess.

I am closing this issue - please feel free follow WebTerminal project, I think it has a good chance to be fixed one day in the future, within the core patch making it 100% compatible with standard Cache Term.