Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent overprompting for permission and account #1456

Merged

Conversation

gjsjohnmurray
Copy link
Contributor

This PR leverages intersystems-community/intersystems-servermanager#243

Requires Server Manager 3.8.0 in order to be effective, but shouldn't break when used with earlier version

Copy link
Contributor

@isc-bsaviano isc-bsaviano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this John. The code looks good. I will create a Language Server issue and get this fixed there tomorrow.

@gjsjohnmurray gjsjohnmurray merged commit fc83973 into intersystems-community:master Nov 12, 2024
5 checks passed
@gjsjohnmurray gjsjohnmurray deleted the brown-kangaroo branch November 12, 2024 22:52
@a-boertien
Copy link
Contributor

hi @gjsjohnmurray @isc-bsaviano
I think there might be a bug with this...
I am being prompted on every file now to authenticate, and I receive this warning on authentication:

image

After selecting "Keep...", the same warning appears next time.
I have also tried signing out of all credentials in VSCode accounts menu.

Versions: server manager 3.8.0, objectscript 2.12.10, VSCode 1.95.2 (windows)

Should I raise a new issue?

@isc-bsaviano
Copy link
Contributor

@a-boertien That's a bug in the Language Server 2.6.4 which is fixed in 2.6.5.

@a-boertien
Copy link
Contributor

Thanks @isc-bsaviano - have just updated to 2.6.5 and it looks resolved!

@a-boertien
Copy link
Contributor

hi @gjsjohnmurray @isc-bsaviano
Just wanted to leave some positive feedback.
I was a long time sufferer of over prompting -- have not noticed any over the last week, so this is a welcome fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants