Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If connect with stored password fails, delete and re-prompt #238

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

gjsjohnmurray
Copy link
Collaborator

This PR fixes #233

To test:

  1. Have a connection with a saved password that works (Namespaces folder appears when server is expanded).
  2. In IRIS Portal, change this user's password.
  3. Reload VS Code window and try to expand the same server.

You should be immediately prompted to allow use of the credentials service, then for the user's password. Enter the new one and save it. Namespaces folder should appear.

Copy link
Contributor

@isc-bsaviano isc-bsaviano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good but I haven't tested

@gjsjohnmurray gjsjohnmurray merged commit 6c18caf into intersystems-community:master Oct 8, 2024
5 checks passed
@gjsjohnmurray
Copy link
Collaborator Author

Merged so there's a published beta for anyone wanting to try it, but I suggest we don't publish the next release for a couple of weeks as I'll be OOO.

@gjsjohnmurray gjsjohnmurray deleted the fix-233 branch October 8, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow an extension using credentials manager to clear bad stored password
2 participants