You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If intercom server returns X-RateLimit-Reset as nil it would crash the app
rate_limit_details becomes nil instead of empty hash if the http client throws an error, while the public interface of the rate_limit_details should always be either empty hash or hash with some data.
Steps to reproduce
X-RateLimit-Reset should not be returned from the server, while handle_rate_limit should be enabled.
This is hard to reproduce because http client initial request on line 61 in class Request "response = http.request(net_http_method)" needs to throw an error, which would set rate_limit_details to nil in the Client class.
Logs
Bug regarding rate_limit_details happened to us because we tried to use rate_limit_details for some custom solution's and at one point it became nil which crash our process.
The text was updated successfully, but these errors were encountered:
Version info
Expected behavior
rate_limit_details
should not be set to nil if the http client throws an errorThis is the PR solution #578
Actual behavior
rate_limit_details
becomes nil instead of empty hash if the http client throws an error, while the public interface of therate_limit_details
should always be either empty hash or hash with some data.Steps to reproduce
handle_rate_limit
should be enabled.rate_limit_details
to nil in the Client class.Logs
Bug regarding
rate_limit_details
happened to us because we tried to userate_limit_details
for some custom solution's and at one point it became nil which crash our process.The text was updated successfully, but these errors were encountered: