Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Port, move to Logic.port for API consistency #506

Closed
mkorbel1 opened this issue Sep 11, 2024 · 2 comments · Fixed by #575
Closed

Deprecate Port, move to Logic.port for API consistency #506

mkorbel1 opened this issue Sep 11, 2024 · 2 comments · Fixed by #575
Assignees
@lucasphillips
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mkorbel1
Copy link
Contributor

Motivation

The "port" style constructors include:

Logic --> Port
LogicArray --> LogicArray.port
LogicNet --> LogicNet.port
LogicArray.net --> LogicArray.netPort

One of these is not like the others. Moving to Logic.port would be more verbose, but create a more consistent API.

Desired solution

Deprecate Port in favor of Logic.port.

Alternatives considered

No response

Additional details

No response
@mkorbel1 mkorbel1 added the enhancement New feature or request label Sep 11, 2024
@mkorbel1 mkorbel1 changed the title Depreacate Port, move to Logic.port for API consistency Deprecate Port, move to Logic.port for API consistency Sep 17, 2024
@mkorbel1 mkorbel1 added the good first issue Good for newcomers label Feb 5, 2025
@lucasphillips
Copy link
Contributor

As part of the 2025 OSS Hackathon, ROHD_Team1 is working on this issue.

@mkorbel1
Copy link
Contributor Author

mkorbel1 commented Mar 3, 2025

Great assigned!

@lucasphillips lucasphillips mentioned this issue Mar 3, 2025
Open
lucasphillips pushed a commit to lucasphillips/rohd that referenced this issue Mar 4, 2025
@curtisan-intel @capp21 @lucasphillips
Replace Port with Logic.port
e0cd1d9 
Deprecate Port and replace with Logic.port to make the API more consistent.
Other classes such as LogicArray and LogicNet already have this style of port constructor.

Implements intel#506

Co-authored-by: Andrew Capatina <[email protected]>
Signed-off-by: Curtis Anderson <[email protected]>
Signed-off-by: Andrew Capatina <[email protected]>
Signed-off-by: Luke Phillips <[email protected]>
@lucasphillips lucasphillips mentioned this issue Mar 4, 2025
Merged
@mkorbel1 mkorbel1 linked a pull request Mar 4, 2025 that will close this issue
Deprecate Port and move to Logic.port for API consistency #575
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucasphillips lucasphillips

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate Port and move to Logic.port for API consistency lucasphillips/rohd
2 participants
@lucasphillips @mkorbel1