Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-txn does not work on AMD metrics #186

Open
hsane-dev opened this issue Jan 29, 2025 · 0 comments
Open

Per-txn does not work on AMD metrics #186

hsane-dev opened this issue Jan 29, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@hsane-dev
Copy link

hsane-dev commented Jan 29, 2025

The pertxn flag has no effect on AMD metrics, needs to add normalization by txn. This will require adding metric definitions where "per txn" is applicable in the metric lists. metrics_defs.go should pick up relevant metrics to normalize:
// swap in per-txn metric definition if transaction rate is provided
if flagTransactionRate != 0 && tmpMetric.ExpressionTxn != "" {
tmpMetric.Expression = tmpMetric.ExpressionTxn
tmpMetric.Expression = strings.ReplaceAll(tmpMetric.Expression, "[TXN]", fmt.Sprintf("%f", flagTransactionRate))
tmpMetric.Name = tmpMetric.NameTxn
}

@harp-intel harp-intel added the enhancement New feature or request label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants