Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Allow scheduled reminders to cascade for subteams #1935

Open
ausdrew opened this issue Aug 19, 2024 · 0 comments
Open

FR: Allow scheduled reminders to cascade for subteams #1935

ausdrew opened this issue Aug 19, 2024 · 0 comments

Comments

@ausdrew
Copy link

ausdrew commented Aug 19, 2024

Is your feature request related to a problem? Please describe.

When configuring scheduled reminders for a team in an organization, it's often desirable to only include pull requests that are stale, and have a review requested.

When 'Require review requests' is turned on within the scheduled reminder, it limits the pull requests displayed to be only those where a review is specifically requested from that team the scheduled reminder was created for.

Optionally, to only include pull requests where a review is specifically requested from the team or a team member, select Require review requests. If you don't select this option, all pull requests are included in the scheduled reminder.

It's common for organizations to have a team of "engineers" for example, which have subteams for different product areas. It would be nice to be able to configure a single scheduled reminder for this overarching team, and have the option to include reviews requested for subteams as well.

Describe the solution you'd like

This could be achieved with an additional option, underneath the "Require review requests" setting, that includes subteams when configuring this.

Or a simpler option could be "Require a review" - but don't scope this to the team the scheduled reminder is created for, just ensure the pull request has at least one reviewer/reviewer team added.

Describe alternatives you've considered

The alternative is creating a new scheduled reminder manually, for each and every subteam, and leaving "Require review requests" turned on. This is cumbersome and repetitive, and makes it difficult to change the settings uniformly across all teams.

Alternatively turning off "Require review requests" and allowing all stale PRs is an option - although the purpose of these reminders in this case is generally to highlight work that is being held up waiting for reviews, so it mightn't be desirable to have pull requests without a review included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant