Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: GitHub workflow post spam completions and messages in a thread even though the threading is disabled for the channel #1924

Open
pombredanne opened this issue Jul 18, 2024 · 10 comments
Labels

Comments

@pombredanne
Copy link

pombredanne commented Jul 18, 2024

Describe the bug
GitHub workflows started recently to post annoying messages in threads even though threading is disabled in the channel /github settings
This is a major annoyance because it creates a large volume of noise and actual important threads that are not GitHub-spam-bot generated are hidden in a sea of useless threaded comments from the workflow.

Expected behavior
Stop spamming threads

@pombredanne
Copy link
Author

Actually recently is not right, it started on July 30th 2023, and became really annoying to me recently because we started using more workflows.

@valeed-srahealth
Copy link

valeed-srahealth commented Jul 26, 2024

Yeah this has totally taken over our slack threads page. Too much noise to be able to track my actual threads now.
image

@alexrobertson-muckrack
Copy link

@valeed-srahealth how did you get to that setting? I'm struggling with this as well.

@valeed-srahealth
Copy link

@alexrobertson-muckrack access it with /github settings.

However I got word from support that that setting does not apply to workflows so there isn't a way to disable threading for workflow notifications.

@pombredanne
Copy link
Author

@valeed-srahealth

However I got word from support that that setting does not apply to workflows so there isn't a way to disable threading for workflow notifications.

ok, so I guess the alternative is to disable workflows or to go to plain webhooks? oh, strike this. Slack webhooks do not work anymore with github.

This is making slack usage miserable as threads are now flooded with junk workflow notifications. They make either Slack threads useless or they make GitHub workflow useless from the churn this triggers.

@rayeedanwar
Copy link

If it helps, I've switched them off for the app and opened a private slack channel for my own notifications - saves me suffering from my thread notifications 😅

@pombredanne
Copy link
Author

@rayeedanwar re: #1924 (comment)

If it helps, I've switched them off for the app and opened a private slack channel for my own notifications - saves me suffering from my thread notifications

This looks interesting: can you elaborate the process? Does this mean removing the Slack github app from all public channels?

@snankani snankani removed their assignment Aug 19, 2024
@rayeedanwar
Copy link

  1. Open Github App messages
  2. Run /github subscribe list features to get a list of all subscriptions
  3. /github unsubscribe org/repo in the private Github App for all subscriptions
  4. Open a new slack channel - private or public as you wish
  5. Resubscribe based on the output of step 2

@pombredanne
Copy link
Author

@rayeedanwar thanks, but I cannot fathom doing this on 100's on channels. This is nuts.
Is there someone from Slack listening here? This unwanted Github integration side effect is effectively ruining the experience of Slack threads

@pombredanne
Copy link
Author

Pinging some slack folks for advice: @amarinelli @seratch @clavin may you can help the GitHub folks make proper use of threads in their integration and avoid ruining the standard Slack UX? 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants