refactor: generated_data as list #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove redundant conversions from None to empty list. Signed-off-by: Costa Shulyupin <[email protected]>
makelinux
force-pushed
the
generated_data
branch
from
03bdf9e to
3fce0a5
Compare
bbrowning
requested changes
Dec 10, 2024
There was a problem hiding this comment.
The tests passed here but I believe it's making a list of lists of Datasets instead of just a list of Datasets. Or it could be that I'm reading the code wrong? However, it's concerning that none of our tests caught this because an extra level of list nesting would surely mess something up.
bbrowning
approved these changes
Dec 10, 2024
|
I need to fix a different bug near this code and don't want to cause a rebase headache for you, so going to go ahead and merge this PR. Thanks for the cleanup help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redundant conversions from None to empty list.