Skip to content

Commit

Permalink
Loosen up md-lint so we can write changelogs
Browse files Browse the repository at this point in the history
Signed-off-by: Ben Browning <[email protected]>
(cherry picked from commit fe31e7d)

# Conflicts:
#	.github/workflows/actionlint.yml
#	.github/workflows/docs.yml
#	.github/workflows/e2e-nvidia-l4-x1.yml
#	.github/workflows/e2e-nvidia-l40s-x4.yml
#	.github/workflows/e2e-nvidia-t4-x1.yml
#	.github/workflows/lint.yml
#	.github/workflows/pypi.yaml
#	.github/workflows/spellcheck.yml
#	.github/workflows/stale_bot.yml
#	.github/workflows/test.yml
#	.markdownlint-cli2.yaml
#	.spellcheck-en-custom.txt
#	README.md
#	requirements-dev.txt
#	requirements.txt
#	src/instructlab/sdg/generate_data.py
#	src/instructlab/sdg/utils/json.py
#	tox.ini
  • Loading branch information
bbrowning authored and mergify[bot] committed Dec 10, 2024
1 parent dd9233c commit 5b5072a
Show file tree
Hide file tree
Showing 18 changed files with 292 additions and 0 deletions.
12 changes: 12 additions & 0 deletions .github/workflows/actionlint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,20 @@ on:
- "main"
- "release-**"
paths:
<<<<<<< HEAD
=======
- '.github/actions/*.ya?ml'
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)
- '.github/workflows/*.ya?ml'
- '.github/workflows/actionlint.*' # This workflow
pull_request:
branches:
- "main"
paths:
<<<<<<< HEAD
=======
- '.github/actions/*.ya?ml'
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)
- '.github/workflows/*.ya?ml'
- '.github/workflows/actionlint.*' # This workflow

Expand All @@ -31,7 +39,11 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: "Harden Runner"
<<<<<<< HEAD
uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1
=======
uses: step-security/harden-runner@0080882f6c36860b6ba35c610c98ce87d4e2f26f # v2.10.2
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)
with:
egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs

Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,11 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: "Harden Runner"
<<<<<<< HEAD
uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1
=======
uses: step-security/harden-runner@0080882f6c36860b6ba35c610c98ce87d4e2f26f # v2.10.2
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)
with:
egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs
- name: "Checkout"
Expand Down
11 changes: 11 additions & 0 deletions .github/workflows/e2e-nvidia-l4-x1.yml
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,11 @@ jobs:
. ../instructlab/venv/bin/activate
pip install -v .
<<<<<<< HEAD
- name: Check disk
=======
- name: Check disk before tests
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)
run: |
df -h
Expand All @@ -142,6 +146,13 @@ jobs:
. venv/bin/activate
./scripts/e2e-ci.sh -m
<<<<<<< HEAD
=======
- name: Check disk after tests
run: |
df -h
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)
stop-medium-ec2-runner:
needs:
- start-medium-ec2-runner
Expand Down
37 changes: 37 additions & 0 deletions .github/workflows/e2e-nvidia-l40s-x4.yml
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,11 @@ jobs:
pip install .
pip install .[cuda]
<<<<<<< HEAD
- name: Check disk
=======
- name: Check disk before tests
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)
run: |
df -h
Expand All @@ -172,6 +176,13 @@ jobs:
. venv/bin/activate
./scripts/e2e-ci.sh -l
<<<<<<< HEAD
=======
- name: Check disk after tests
run: |
df -h
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)
- name: Add comment to PR if the workflow failed
if: failure() && steps.check_pr.outputs.is_pr == 'true'
working-directory: ./sdg
Expand All @@ -191,6 +202,7 @@ jobs:
- name: Post job results to Slack if the workflow failed
if: failure() && steps.check_pr.outputs.is_pr == 'false'
id: slack-report-failure
<<<<<<< HEAD
uses: slackapi/slack-github-action@37ebaef184d7626c5f204ab8d3baff4262dd30f0 # v1.27.0
with:
# Slack channel id, channel name, or user id to post message.
Expand All @@ -200,10 +212,23 @@ jobs:
slack-message: "*e2e-nvidia-l40s-x4* job in *${{ github.repository }}* running on branch `${{ steps.check_pr.outputs.pr_or_branch }}` completed *with failures* :meow_sad-rain: | ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
env:
SLACK_BOT_TOKEN: ${{ secrets.SON_OF_JEEVES_TOKEN }}
=======
uses: slackapi/slack-github-action@485a9d42d3a73031f12ec201c457e2162c45d02d # v2.0.0
with:
token: ${{ secrets.SON_OF_JEEVES_TOKEN }}
method: chat.postMessage
payload: |
# Slack channel id, channel name, or user id to post message.
# See also: https://api.slack.com/methods/chat.postMessage#channels
# You can pass in multiple channels to post to by providing a comma-delimited list of channel IDs.
channel: 'e2e-ci-results'
text: "*e2e-nvidia-l40s-x4* job in *${{ github.repository }}* running on branch `${{ steps.check_pr.outputs.pr_or_branch }}` completed *with failures* :meow_sad-rain: | ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)

- name: Post job results to Slack if the workflow succeeded
if: success() && steps.check_pr.outputs.is_pr == 'false'
id: slack-report-success
<<<<<<< HEAD
uses: slackapi/slack-github-action@37ebaef184d7626c5f204ab8d3baff4262dd30f0 # v1.27.0
with:
# Slack channel id, channel name, or user id to post message.
Expand All @@ -213,6 +238,18 @@ jobs:
slack-message: "*e2e-nvidia-l40s-x4* job in *${{ github.repository }}* running on branch `${{ steps.check_pr.outputs.pr_or_branch }}` completed *successfully* :meow_party: | ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
env:
SLACK_BOT_TOKEN: ${{ secrets.SON_OF_JEEVES_TOKEN }}
=======
uses: slackapi/slack-github-action@485a9d42d3a73031f12ec201c457e2162c45d02d # v2.0.0
with:
token: ${{ secrets.SON_OF_JEEVES_TOKEN }}
method: chat.postMessage
payload: |
# Slack channel id, channel name, or user id to post message.
# See also: https://api.slack.com/methods/chat.postMessage#channels
# You can pass in multiple channels to post to by providing a comma-delimited list of channel IDs.
channel: 'e2e-ci-results'
text: "*e2e-nvidia-l40s-x4* job in *${{ github.repository }}* running on branch `${{ steps.check_pr.outputs.pr_or_branch }}` completed *successfully* :meow_party: | ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)

stop-large-ec2-runner:
needs:
Expand Down
11 changes: 11 additions & 0 deletions .github/workflows/e2e-nvidia-t4-x1.yml
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,11 @@ jobs:
. ../instructlab/venv/bin/activate
pip install .
<<<<<<< HEAD
- name: Check disk
=======
- name: Check disk before tests
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)
run: |
df -h
Expand All @@ -138,6 +142,13 @@ jobs:
. venv/bin/activate
./scripts/e2e-ci.sh -s
<<<<<<< HEAD
=======
- name: Check disk after tests
run: |
df -h
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)
stop-small-ec2-runner:
needs:
- start-small-ec2-runner
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,11 @@ jobs:
tox -e validate-pipelines
steps:
- name: "Harden Runner"
<<<<<<< HEAD
uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1
=======
uses: step-security/harden-runner@0080882f6c36860b6ba35c610c98ce87d4e2f26f # v2.10.2
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)
with:
egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs

Expand Down
20 changes: 20 additions & 0 deletions .github/workflows/pypi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,11 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: "Harden Runner"
<<<<<<< HEAD
uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1
=======
uses: step-security/harden-runner@0080882f6c36860b6ba35c610c98ce87d4e2f26f # v2.10.2
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)
with:
egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs

Expand Down Expand Up @@ -67,7 +71,11 @@ jobs:

steps:
- name: "Harden Runner"
<<<<<<< HEAD
uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1
=======
uses: step-security/harden-runner@0080882f6c36860b6ba35c610c98ce87d4e2f26f # v2.10.2
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)
with:
egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs

Expand All @@ -78,7 +86,11 @@ jobs:
path: dist

- name: "Upload to Test PyPI"
<<<<<<< HEAD
uses: pypa/gh-action-pypi-publish@15c56dba361d8335944d31a2ecd17d700fc7bcbc # v1.12.2
=======
uses: pypa/gh-action-pypi-publish@67339c736fd9354cd4f8cb0b744f2b82a74b5c70 # v1.12.3
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)
with:
repository-url: https://test.pypi.org/legacy/

Expand All @@ -99,7 +111,11 @@ jobs:

steps:
- name: "Harden Runner"
<<<<<<< HEAD
uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1
=======
uses: step-security/harden-runner@0080882f6c36860b6ba35c610c98ce87d4e2f26f # v2.10.2
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)
with:
egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs

Expand Down Expand Up @@ -130,4 +146,8 @@ jobs:
rm ./dist/*.sigstore.json
- name: "Upload to PyPI"
<<<<<<< HEAD
uses: pypa/gh-action-pypi-publish@15c56dba361d8335944d31a2ecd17d700fc7bcbc # v1.12.2
=======
uses: pypa/gh-action-pypi-publish@67339c736fd9354cd4f8cb0b744f2b82a74b5c70 # v1.12.3
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)
4 changes: 4 additions & 0 deletions .github/workflows/spellcheck.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,11 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: "Harden Runner"
<<<<<<< HEAD
uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1
=======
uses: step-security/harden-runner@0080882f6c36860b6ba35c610c98ce87d4e2f26f # v2.10.2
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)
with:
egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs

Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/stale_bot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: "Harden Runner"
<<<<<<< HEAD
uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1
=======
uses: step-security/harden-runner@0080882f6c36860b6ba35c610c98ce87d4e2f26f # v2.10.2
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)
with:
egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs

Expand Down
12 changes: 12 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ jobs:
name: "${{ matrix.python }} on ${{ matrix.platform }}"
runs-on: "${{ matrix.platform }}"
strategy:
<<<<<<< HEAD
=======
fail-fast: false
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)
matrix:
python:
- "3.10"
Expand All @@ -51,7 +55,11 @@ jobs:
platform: "macos-latest"
steps:
- name: "Harden Runner"
<<<<<<< HEAD
uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1
=======
uses: step-security/harden-runner@0080882f6c36860b6ba35c610c98ce87d4e2f26f # v2.10.2
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)
with:
egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs

Expand Down Expand Up @@ -89,7 +97,11 @@ jobs:
pip cache remove llama_cpp_python
- name: Cache huggingface
<<<<<<< HEAD
uses: actions/cache@6849a6489940f00c2f30c0fb92c6274307ccb58a # v4.1.2
=======
uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v4.2.0
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)
with:
path: ~/.cache/huggingface
# config contains DEFAULT_MODEL
Expand Down
8 changes: 8 additions & 0 deletions .markdownlint-cli2.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,18 @@ config:
code-block-style: false
no-duplicate-header: false
single-trailing-newline: false
<<<<<<< HEAD
=======
no-duplicate-heading: false
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)
globs:
- "**/*.md"
ignores:
- ".github/**"
<<<<<<< HEAD
=======
- ".tox/**"
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)
- "venv/**"
- ".venv/**"
- "**/testdata/**"
36 changes: 36 additions & 0 deletions .spellcheck-en-custom.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,21 @@
Backport
backported
codebase
<<<<<<< HEAD
=======
configs
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)
Dataset
dataset
datasets
distractor
<<<<<<< HEAD
=======
Docling
docling
Eval
eval
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)
FIXME
freeform
ICL
Expand All @@ -17,6 +28,7 @@ Langchain's
LLM
LLMBlock
MCQ
<<<<<<< HEAD
MMLU
Ouput
Pre
Expand All @@ -29,6 +41,30 @@ Splitter
subfolder
Tatsu
unchunked
=======
Merlinite
Mixtral
MMLU
multiphase
Ouput
Pre
pre
precomputed
Pregenerated
qna
quantized
repo
sdg
Splitter
subdirectory
subfolder
Tatsu
Tesseract
tokenizer
tokenizers
unchunked
upsampled
>>>>>>> fe31e7d (Loosen up md-lint so we can write changelogs)
UUID
vLLM
yaml
Loading

0 comments on commit 5b5072a

Please sign in to comment.