-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uniform dhcpv4 and dhcpv6 Parse methods #22
Comments
Do you have any preference of one over the other? |
I prefer the dhcpv6 convention but happy to discuss |
Leaving this open since we now need to simplify the dhcpv6 parsing using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The dhcpv4 and dhcpv6 packages use two different conventions for option parsing. In
dhcpv4
the option is parsed along with option code and length, indhcpv6
these are handled earlier, and theParse*
methods only handle the data, assuming that the option code is the same as the used option.Let's uniform the two interfaces for consistency.
The text was updated successfully, but these errors were encountered: