Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide latest immutable file number with certified Cardano transactions in client #1536

Closed
9 tasks done
jpraynaud opened this issue Feb 27, 2024 · 1 comment · Fixed by #1571
Closed
9 tasks done
Assignees
Labels
devX 🌞 Developer experience

Comments

@jpraynaud
Copy link
Member

jpraynaud commented Feb 27, 2024

Why

We want to provide extra information (latest beacon -immutable file number or block number-) along with the certified status of a transaction in the Mithril client. This information should also be signed by the protocol.

What

In order to guarantee the latest immutable file number or block number value displayed along the verified transactions, we need to make it part of the protocol message signed by Mithril.

How

  • Add the latest signed immutable file number or block number in the protocol message signed
  • Include the latest signed immutable file number or block number in the proof generated by the aggregator
  • Verify that the latest signed immutable file number or block number is valid in the client
    • library
    • CLI
    • WASM
  • Update examples
  • Update documentation
  • Clean stale data in testing-sanchonet (e.g. Cardano transactions certificate already signer, ...)

Related issue

#1561

@jpraynaud jpraynaud added the devX 🌞 Developer experience label Feb 27, 2024
@ch1bo
Copy link
Member

ch1bo commented Mar 7, 2024

FWIW my original request to provide data representing the "recency" of the data on which we verified the transactions. Whether this is a block number, slot number of the corresponding wall-clock time of these does not matter. Why is this needed? To make sense of the outcome, i.e. know whether it's just not "valid yet" and we can hope to verify again later, or (more important) whether the checked txid is invalid (although it should) = maybe someone cheated me (whoever claimed the tx to be valid).

It is not important to me which tx is coming from which block, rather from when the proofs are.

As you mentioned @jpraynaud that timepoint must be signed with the transaction originally and be verifiable by the client code.

@jpraynaud jpraynaud added the to-groom 🤔 Needs grooming label Mar 7, 2024
@jpraynaud jpraynaud changed the title Provide block number with certified Cardano transactions Provide latest immutable file number with certified Cardano transactions Mar 11, 2024
@jpraynaud jpraynaud removed the to-groom 🤔 Needs grooming label Mar 11, 2024
@jpraynaud jpraynaud changed the title Provide latest immutable file number with certified Cardano transactions Provide latest immutable file number with certified Cardano transactions in client Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devX 🌞 Developer experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants