Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential deadlock in simHasFS #82

Open
jorisdral opened this issue Oct 28, 2024 · 0 comments
Open

Potential deadlock in simHasFS #82

jorisdral opened this issue Oct 28, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jorisdral
Copy link
Collaborator

sim :: FSSimT m a -> m a
sim m = do
st <- atomically $ takeTMVar var
runFSSimT m st >>= \case
Left e -> do
atomically $ putTMVar var st
throwIO e
Right (a, st') -> do
atomically $ putTMVar var st'
pure a

If an exception happens between takeTMVar and putTMVar, then the TMVar will be left empty. This is a potential deadlock situation

@jorisdral jorisdral added the bug Something isn't working label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant