-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow pinning the content of remote sources with hashes #45
Comments
💯 Questions/thoughts:
|
I think SHA256 is generally good enough, and also we don't want to make these too difficult to produce, since we'll want
I think "whatever gets fetched from the URL" seems reasonable? |
Putting in the hashes for old things will be annoying. We could have a |
Another reason to do this: it gives us a bit more security against supply-chain attacks. At the moment we use github URLs a lot. These have git shas in them... but these days it's possible to manufacture collisions in git's hash algorithm. A concrete example: if we move a repository from SHA-256 is still collision-resistant, so if we had hashes in the |
This protects us against the use of mutable URL references, and also makes things more Nix friendly.
We might want to make it possible to require this.
The text was updated successfully, but these errors were encountered: